Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of crashfix in AddSqlServerHealthContributor #1094

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Backport of crashfix in AddSqlServerHealthContributor #1094

merged 2 commits into from
Jan 18, 2023

Conversation

bart-vmware
Copy link
Member

Description

Backport of #1090 from main into release/3.2

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware bart-vmware changed the title Backport of https://github.com/SteeltoeOSS/Steeltoe/pull/1090 Backport of crashfix in AddSqlServerHealthContributor Jan 16, 2023
@bart-vmware
Copy link
Member Author

bart-vmware commented Jan 16, 2023 •
edited

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bart-vmware bart-vmware marked this pull request as ready for review January 16, 2023 16:01
TimHess
TimHess reviewed Jan 17, 2023
View reviewed changes
versions.props Outdated Show resolved Hide resolved
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

hananiel
hananiel approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@hananiel hananiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@bart-vmware bart-vmware merged commit acb54d0 into release/3.2 Jan 18, 2023
@bart-vmware bart-vmware deleted the backport-1090 branch January 18, 2023 15:37
@bart-vmware bart-vmware mentioned this pull request Jan 19, 2023
Merged
@TimHess TimHess added this to the 3.2.3 milestone Feb 8, 2023
@TimHess TimHess added Component/Connectors Issues related to Steeltoe connectors ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimHess TimHess TimHess left review comments

@hananiel hananiel hananiel approved these changes

Assignees
No one assigned
Labels
Component/Connectors Issues related to Steeltoe connectors ReleaseLine/3.x Identified as a feature/fix for the 3.x release line
Projects
None yet
Milestone
3.2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bart-vmware @hananiel @TimHess