Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigurationUrlHelper Enhancements #1190

Merged
merged 5 commits into from
Oct 4, 2023
Merged

ConfigurationUrlHelper Enhancements #1190

merged 5 commits into from
Oct 4, 2023

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Sep 29, 2023 •
edited
Loading

Description

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Type/bug Something isn't working Type/enhancement New feature or request Component/Discovery Issues related to Steeltoe Service Discovery Component/Common ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Sep 29, 2023
@TimHess TimHess added this to the 4.0.0-m1 milestone Sep 29, 2023
@TimHess TimHess self-assigned this Sep 29, 2023
@TimHess
Copy link
Member Author

TimHess commented Sep 29, 2023 •
edited
Loading

/azp run cleanup-code

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Code cleanup successfully reformatted files and pushed changes.

@TimHess
handle trailing semicolon in aspnet urls, move ConfigurationUrlHelpers
1382d77 
handle trailing semicolon in aspnet urls
move ConfigurationUrlHelpers to Steeltoe.Common.Http
update wildcard handling in host url
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess
Copy link
Member Author

TimHess commented Oct 3, 2023

/azp run cleanup-code

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

hananiel
hananiel previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@hananiel hananiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azure-pipelines
Copy link

Code cleanup successfully reformatted files and pushed changes.

@TimHess TimHess requested a review from hananiel October 3, 2023 19:04
@TimHess TimHess merged commit 4d7a6ae into main Oct 4, 2023
16 checks passed
@TimHess TimHess deleted the url_helpers branch October 4, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hananiel hananiel hananiel approved these changes

@bart-vmware bart-vmware Awaiting requested review from bart-vmware

Assignees

@TimHess TimHess

Labels
Component/Common Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/bug Something isn't working Type/enhancement New feature or request
Projects
None yet
Milestone
4.0.0-m1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TimHess @hananiel