Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Boot Admin Integration enhancements #490

Open
TimHess opened this issue Oct 28, 2020 · 1 comment
Open

Spring Boot Admin Integration enhancements #490

TimHess opened this issue Oct 28, 2020 · 1 comment
Labels
Component/Management Issues related to Steeltoe Management (actuators) Type/enhancement New feature or request
Milestone
4.0.0-m2

Comments

@TimHess
Copy link
Member

TimHess commented Oct 28, 2020 •
edited
Loading

ConfigurationUrlHelpers should move to a more centralized location so they can also be used for registering with Spring Boot Admin.

Consider adding extension(s) for program.cs and/or including with general actuator setup for a more polished experience.
@TimHess TimHess added Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/enhancement New feature or request labels Oct 28, 2020
@TimHess TimHess added this to the 4.0.0 milestone Feb 7, 2022
@TimHess TimHess removed the ReleaseLine/3.x Identified as a feature/fix for the 3.x release line label Aug 1, 2022
@TimHess TimHess mentioned this issue Apr 4, 2023
Closed
TimHess added a commit that referenced this issue Sep 29, 2023
@TimHess
handle trailing semicolon in aspnet urls, move ConfigurationUrlHelper…
fcd918a 
…s to Steeltoe.Common.Http (#490), update wildcard handling in host url
@TimHess TimHess mentioned this issue Sep 29, 2023
Merged
5 tasks
TimHess added a commit that referenced this issue Sep 29, 2023
@TimHess
handle trailing semicolon in aspnet urls, move ConfigurationUrlHelper…
723e038 
…s to Steeltoe.Common.Http (#490), update wildcard handling in host url
@TimHess TimHess removed this from the 4.0.0-m1 milestone Nov 27, 2023
@TimHess TimHess added this to the 4.0.0-m2 milestone Jul 5, 2024
@TimHess TimHess mentioned this issue Aug 15, 2024
Merged
5 tasks
@bart-vmware
Copy link
Member

Currently (main), the code first looks for spring:boot:admin:client:basePath in configuration, then falls back to using the hostname in the bound ASP.NET listen addresses (unlikely to find it there), then fails with an error.

Eureka uses several strategies for determining the hostname, we should explore if we can borrow from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component/Management Issues related to Steeltoe Management (actuators) Type/enhancement New feature or request
Projects
None yet
Milestone
4.0.0-m2
Development

No branches or pull requests
2 participants
@TimHess @bart-vmware