-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actuators3 #361
Actuators3 #361
Conversation
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 53.05% 53.80% +0.74%
==========================================
Files 1134 1124 -10
Lines 37729 37759 +30
Branches 7112 7095 -17
==========================================
+ Hits 20018 20315 +297
+ Misses 15985 15702 -283
- Partials 1726 1742 +16
Continue to review full report at Codecov.
|
With the removal of most of the |
They will have to use Map (if using the services.AddXXX() and correlated Map) . But the best thing is the HostBuilder extensions that call both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Close, needs some conversation & relatively minor tweaks
src/Management/src/EndpointCore/SpringBootAdminClient/HttpClientExtensions.cs
Outdated
Show resolved
Hide resolved
src/Management/test/CloudFoundryCore.Test/CloudFoundryHostBuilderExtensionsTest.cs
Outdated
Show resolved
Hide resolved
src/Management/test/EndpointCore.Test/ActuatorRouteBuilderExtensionsTest.cs
Show resolved
Hide resolved
src/Management/src/EndpointCore/ActuatorRouteBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Management/src/EndpointCore/ActuatorServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Hess <thess@pivotal.io>
src/Management/src/EndpointCore/ActuatorRouteBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Management/src/EndpointCore/ActuatorRouteBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Management/src/EndpointCore/ActuatorServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Management/src/EndpointCore/ActuatorRouteBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Management/src/EndpointCore/ActuatorServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Hess <thess@pivotal.io>
This reverts commit fc71eb7.
Kudos, SonarCloud Quality Gate passed!
|
resolves #341 #253