Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actuators3 #361

Merged
merged 17 commits into from
Jun 29, 2020
Merged

Actuators3 #361

merged 17 commits into from
Jun 29, 2020

Conversation

hananiel
Copy link
Contributor

@hananiel hananiel commented Jun 25, 2020

resolves #341 #253

  • Removes Obsoleted Code
  • Removes newtonSoft in Management (to System.Text.Json)
  • Makes middleware endpoint enabled - Which allows you to Map
  • Added an AddAllActuators HostBuilder extension
  • Added code coverage for HealthRegistrations

@hananiel hananiel requested a review from TimHess June 25, 2020 03:06
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #361 into master will increase coverage by 0.74%.
The diff coverage is 88.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   53.05%   53.80%   +0.74%     
==========================================
  Files        1134     1124      -10     
  Lines       37729    37759      +30     
  Branches     7112     7095      -17     
==========================================
+ Hits        20018    20315     +297     
+ Misses      15985    15702     -283     
- Partials     1726     1742      +16     
Impacted Files Coverage Δ
...entsCore/EventSources/HystrixEventSourceService.cs 70.17% <ø> (ø)
...csEventsCore/HystrixServiceCollectionExtensions.cs 92.59% <ø> (ø)
...uitBreaker/src/HystrixBase/Util/HystrixShutdown.cs 100.00% <ø> (ø)
...Common/src/Common.RetryPolly/PollyRetryTemplate.cs 6.25% <ø> (ø)
...ommon/Transaction/AbstractTransactionDefinition.cs 0.00% <ø> (ø)
...ommon/Transaction/AbstractTransactionOperations.cs 0.00% <ø> (ø)
...Base/ConfigServerConfigurationBuilderExtensions.cs 73.68% <ø> (ø)
...rc/ConfigServerBase/ConfigurationSettingsHelper.cs 98.91% <ø> (ø)
...figServerCore/ConfigServerHostBuilderExtensions.cs 100.00% <ø> (ø)
...c/PlaceholderCore/PlaceholderResolverExtensions.cs 100.00% <ø> (ø)
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fb12e...7395630. Read the comment docs.

@TimHess
Copy link
Member

TimHess commented Jun 25, 2020

With the removal of most of the *ApplicationBuilderExtensions, are you expecting that people will no longer use startup.cs to add actuators, or that they'll just call endpoints.Map<TEndpoint>(); if/when they don't want to use the *HostBuilderExtensions?

@hananiel
Copy link
Contributor Author

hananiel commented Jun 25, 2020

expecting that people will no longer use startup.cs to add actuators, or that they'll just call endpoints.Map<TEndpoint>(); if/when they don't want to use the *Ho

They will have to use Map (if using the services.AddXXX() and correlated Map) . But the best thing is the HostBuilder extensions that call both.

Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close, needs some conversation & relatively minor tweaks

@TimHess TimHess added ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Component/Management Issues related to Steeltoe Management (actuators) labels Jun 25, 2020
@TimHess TimHess added this to the 3.0.0-M3 milestone Jun 25, 2020
@hananiel hananiel requested a review from TimHess June 28, 2020 20:55
Co-authored-by: Tim Hess <thess@pivotal.io>
TimHess
TimHess previously approved these changes Jun 29, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

90.5% 90.5% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Warn/breaking-change There is a breaking change in the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Another Extension to Use Most/All Actuators
2 participants