SteeltoeOSS · hananiel · Jun 29, 2020 · Jun 5, 2020 · Jun 6, 2020 · Jun 18, 2020
diff --git a/sharedproject.props b/sharedproject.props
@@ -19,7 +19,7 @@
     <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
     <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
     <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
-    <NoWarn>SA1101;SA1124;S1128;SA1201;SA1309;SA1310;SA1314;SA1401;SA1413;SA1600;SA1629;SA1652;1591;S1854</NoWarn>
+    <NoWarn>SA1101;SA1124;S1128;SA1201;SA1309;SA1310;SA1314;SA1401;SA1402;SA1413;SA1600;SA1629;SA1652;1591;S1854</NoWarn>
     <CodeAnalysisRuleSet>..\..\..\..\Steeltoe.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
   <PropertyGroup>

diff --git a/sharedtest.props b/sharedtest.props
@@ -1,6 +1,6 @@
 <Project>
   <PropertyGroup>
-    <NoWarn>SA0001;SA1101;SA1124;SA1200;SA1201;SA1208;SA1309;SA1310;SA1314;SA1401;SA1413;SA1600;SA1629;SA1652;1591;CS8002;CA1063</NoWarn>
+    <NoWarn>SA0001;SA1101;SA1124;SA1200;SA1201;SA1208;SA1309;SA1310;SA1314;SA1401;SA1402;SA1413;SA1600;SA1629;SA1652;1591;CS8002;CA1063</NoWarn>
   </PropertyGroup>
   <PropertyGroup>
     <LangVersion>latest</LangVersion>

diff --git a/src/CircuitBreaker/src/Hystrix.MetricsEventsCore/EventSources/HystrixEventSourceService.cs b/src/CircuitBreaker/src/Hystrix.MetricsEventsCore/EventSources/HystrixEventSourceService.cs
@@ -6,7 +6,6 @@
 using Steeltoe.CircuitBreaker.Hystrix.CircuitBreaker;
 using Steeltoe.CircuitBreaker.Hystrix.Metric.Consumer;
 using System;
-using System.Collections.Generic;
 using System.Reactive.Concurrency;
 using System.Reactive.Linq;
 using System.Threading;

diff --git a/src/CircuitBreaker/src/Hystrix.MetricsEventsCore/HystrixServiceCollectionExtensions.cs b/src/CircuitBreaker/src/Hystrix.MetricsEventsCore/HystrixServiceCollectionExtensions.cs
@@ -10,7 +10,6 @@
 using Steeltoe.CircuitBreaker.Hystrix.Metric.Sample;
 using Steeltoe.CircuitBreaker.Hystrix.MetricsEventsCore.EventSources;
 using System;
-using System.Diagnostics.Tracing;
 
 namespace Steeltoe.CircuitBreaker.Hystrix
 {

diff --git a/src/CircuitBreaker/src/HystrixBase/Util/HystrixShutdown.cs b/src/CircuitBreaker/src/HystrixBase/Util/HystrixShutdown.cs
@@ -3,9 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using Steeltoe.CircuitBreaker.Hystrix.Metric.Consumer;
-using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace Steeltoe.CircuitBreaker.HystrixBase.Util
 {

diff --git a/...cuitBreaker/test/Hystrix.MetricsEventsCore.Test/HystrixServiceCollectionExtensionsTest.cs b/...cuitBreaker/test/Hystrix.MetricsEventsCore.Test/HystrixServiceCollectionExtensionsTest.cs
@@ -4,8 +4,6 @@
 
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Hosting;
-using Steeltoe.CircuitBreaker.Hystrix.MetricsEventsCore.EventSources;
 using System;
 using Xunit;
 

diff --git a/src/Common/src/Common.RetryPolly/PollyRetryTemplate.cs b/src/Common/src/Common.RetryPolly/PollyRetryTemplate.cs
@@ -4,7 +4,6 @@
 
 using Polly;
 using Polly.Contrib.WaitAndRetry;
-using Polly.Retry;
 using Steeltoe.Common.Util;
 using System;
 using System.Collections.Generic;

diff --git a/src/Common/src/Common/Transaction/AbstractTransactionDefinition.cs b/src/Common/src/Common/Transaction/AbstractTransactionDefinition.cs
@@ -2,10 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
-using System.Text;
-
 namespace Steeltoe.Common.Transaction
 {
     public abstract class AbstractTransactionDefinition : ITransactionDefinition

diff --git a/src/Common/src/Common/Transaction/AbstractTransactionOperations.cs b/src/Common/src/Common/Transaction/AbstractTransactionOperations.cs
@@ -3,8 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace Steeltoe.Common.Transaction
 {

diff --git a/src/Common/src/Common/Transaction/AbstractTransactionSynchronization.cs b/src/Common/src/Common/Transaction/AbstractTransactionSynchronization.cs
@@ -2,10 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using System;
-using System.Collections.Generic;
-using System.Text;
-
 namespace Steeltoe.Common.Transaction
 {
     public abstract class AbstractTransactionSynchronization : ITransactionSynchronization

diff --git a/src/Common/test/Common.Kubernetes.Test/KubernetesApplicationOptionsTest.cs b/src/Common/test/Common.Kubernetes.Test/KubernetesApplicationOptionsTest.cs
@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using Microsoft.Extensions.Configuration;
-using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;

diff --git a/src/Configuration/src/ConfigServerBase/ConfigServerConfigurationBuilderExtensions.cs b/src/Configuration/src/ConfigServerBase/ConfigServerConfigurationBuilderExtensions.cs
@@ -4,7 +4,6 @@
 
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
-using Steeltoe.Common;
 using Steeltoe.Extensions.Configuration.CloudFoundry;
 using System;
 using System.Linq;

diff --git a/src/Configuration/src/ConfigServerBase/ConfigurationSettingsHelper.cs b/src/Configuration/src/ConfigServerBase/ConfigurationSettingsHelper.cs
@@ -5,7 +5,6 @@
 using Microsoft.Extensions.Configuration;
 using Steeltoe.Common.Configuration;
 using System;
-using System.Collections.Generic;
 
 namespace Steeltoe.Extensions.Configuration.ConfigServer
 {

diff --git a/src/Configuration/src/ConfigServerCore/ConfigServerHostBuilderExtensions.cs b/src/Configuration/src/ConfigServerCore/ConfigServerHostBuilderExtensions.cs
@@ -5,8 +5,6 @@
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
-using System;
-using System.Collections.Generic;
 
 namespace Steeltoe.Extensions.Configuration.ConfigServer
 {

diff --git a/src/Configuration/src/ConfigServerCore/Properties/AssemblyInfo.cs b/src/Configuration/src/ConfigServerCore/Properties/AssemblyInfo.cs
@@ -2,9 +2,7 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using System.Reflection;
 using System.Runtime.CompilerServices;
-using System.Runtime.InteropServices;
 
 [assembly: InternalsVisibleTo("Steeltoe.Extensions.Configuration.ConfigServerCore.Test")]
 [assembly: InternalsVisibleTo("Pivotal.Extensions.Configuration.ConfigServerCore.Test")]
diff --git a/src/Configuration/src/PlaceholderCore/PlaceholderResolverExtensions.cs b/src/Configuration/src/PlaceholderCore/PlaceholderResolverExtensions.cs
@@ -8,7 +8,6 @@
 using Microsoft.Extensions.DependencyInjection.Extensions;
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
-using Steeltoe.Extensions.Configuration.Placeholder;
 using System;
 
 namespace Steeltoe.Extensions.Configuration.Placeholder

diff --git a/src/Configuration/test/CloudFoundryBase.Test/AbstractServiceOptionsTest.cs b/src/Configuration/test/CloudFoundryBase.Test/AbstractServiceOptionsTest.cs
@@ -4,8 +4,6 @@
 
 using Microsoft.Extensions.Configuration;
 using System;
-using System.Collections.Generic;
-using System.Text;
 using Xunit;
 
 namespace Steeltoe.Extensions.Configuration.CloudFoundry.Test

diff --git a/src/Configuration/test/CloudFoundryBase.Test/CloudFoundryApplicationOptionsTest.cs b/src/Configuration/test/CloudFoundryBase.Test/CloudFoundryApplicationOptionsTest.cs
@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using Microsoft.Extensions.Configuration;
-using System;
 using System.Linq;
 using Xunit;
 

diff --git a/src/Configuration/test/CloudFoundryBase.Test/CloudfoundryConfigurationProviderTest.cs b/src/Configuration/test/CloudFoundryBase.Test/CloudfoundryConfigurationProviderTest.cs
@@ -2,10 +2,7 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Microsoft.Extensions.Configuration;
 using System;
-using System.Collections.Generic;
-using System.IO;
 using Xunit;
 
 namespace Steeltoe.Extensions.Configuration.CloudFoundry.Test

diff --git a/...nfiguration/test/ConfigServer.ITest/ConfigServerConfigurationExtensionsIntegrationTest.cs b/...nfiguration/test/ConfigServer.ITest/ConfigServerConfigurationExtensionsIntegrationTest.cs
@@ -6,7 +6,6 @@
 using Microsoft.AspNetCore.TestHost;
 using Microsoft.Extensions.Configuration;
 using Steeltoe.Common;
-using Steeltoe.Extensions.Configuration.ConfigServer;
 using System.IO;
 using Xunit;
 

diff --git a/...onfiguration/test/ConfigServerBase.Test/ConfigServerConfigurationBuilderExtensionsTest.cs b/...onfiguration/test/ConfigServerBase.Test/ConfigServerConfigurationBuilderExtensionsTest.cs
@@ -4,7 +4,6 @@
 
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
-using Steeltoe.Common;
 using Steeltoe.Common.Security;
 using Steeltoe.Extensions.Configuration.CloudFoundry;
 using System;

diff --git a/src/Configuration/test/ConfigServerBase.Test/ConfigServerConfigurationSourceTest.cs b/src/Configuration/test/ConfigServerBase.Test/ConfigServerConfigurationSourceTest.cs
@@ -7,8 +7,6 @@
 using Microsoft.Extensions.Logging;
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Text;
 using Xunit;
 
 namespace Steeltoe.Extensions.Configuration.ConfigServer.Test

diff --git a/src/Configuration/test/ConfigServerBase.Test/ConfigServerHealthContributorTest.cs b/src/Configuration/test/ConfigServerBase.Test/ConfigServerHealthContributorTest.cs
@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using Microsoft.Extensions.Configuration;
-using Steeltoe.Common;
 using Steeltoe.Common.HealthChecks;
 using Steeltoe.Extensions.Configuration.Placeholder;
 using System;

diff --git a/src/Configuration/test/ConfigServerBase.Test/ConfigurationSettingsHelperTest.cs b/src/Configuration/test/ConfigServerBase.Test/ConfigurationSettingsHelperTest.cs
@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using Microsoft.Extensions.Configuration;
-using Steeltoe.Common;
 using System;
 using System.Collections.Generic;
 using Xunit;

diff --git a/...Configuration/test/PlaceholderBase.Test/PlaceholderResolverConfigurationExtensionsTest.cs b/...Configuration/test/PlaceholderBase.Test/PlaceholderResolverConfigurationExtensionsTest.cs
@@ -4,7 +4,6 @@
 
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
-using Steeltoe.Common;
 using System;
 using System.Collections.Generic;
 using System.IO;

diff --git a/src/Configuration/test/PlaceholderBase.Test/PlaceholderResolverProviderTest.cs b/src/Configuration/test/PlaceholderBase.Test/PlaceholderResolverProviderTest.cs
@@ -4,7 +4,6 @@
 
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
-using Steeltoe.Common;
 using System;
 using System.Collections.Generic;
 using System.IO;

diff --git a/src/Configuration/test/PlaceholderBase.Test/PlaceholderResolverSourceTest.cs b/src/Configuration/test/PlaceholderBase.Test/PlaceholderResolverSourceTest.cs
@@ -7,8 +7,6 @@
 using Microsoft.Extensions.Logging;
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Text;
 using Xunit;
 
 namespace Steeltoe.Extensions.Configuration.Placeholder.Test

diff --git a/src/Configuration/test/PlaceholderCore.Test/PlaceholderServiceCollectionExtensionsTest.cs b/src/Configuration/test/PlaceholderCore.Test/PlaceholderServiceCollectionExtensionsTest.cs
@@ -7,7 +7,6 @@
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
-using Steeltoe.Common;
 using System;
 using System.Collections.Generic;
 using System.IO;

diff --git a/src/Configuration/test/RandomValuesBase.Test/RandomValueExtensionsTest.cs b/src/Configuration/test/RandomValuesBase.Test/RandomValueExtensionsTest.cs
@@ -3,11 +3,8 @@
 // See the LICENSE file in the project root for more information.
 
 using Microsoft.Extensions.Configuration;
-using Microsoft.Extensions.Logging;
 using System;
 using System.Collections.Generic;
-using System.IO;
-using System.Linq;
 using Xunit;
 
 namespace Steeltoe.Extensions.Configuration.RandomValue.Test

diff --git a/src/Connectors/src/Connector.EF6Core/OracleDbContextServiceCollectionExtensions.cs b/src/Connectors/src/Connector.EF6Core/OracleDbContextServiceCollectionExtensions.cs
@@ -4,7 +4,6 @@
 
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Logging;
 using Steeltoe.Connector.Oracle;
 using Steeltoe.Connector.Oracle.EF6;
 using Steeltoe.Connector.Services;

diff --git a/...tors/test/Connector.EF6Core.Net4Test/SqlServerDbContextServiceCollectionExtensionsTest.cs b/...tors/test/Connector.EF6Core.Net4Test/SqlServerDbContextServiceCollectionExtensionsTest.cs
@@ -4,10 +4,8 @@
 
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
-using Steeltoe.Connector.Test;
 using Steeltoe.Extensions.Configuration.CloudFoundry;
 using System;
-using System.Data.Entity;
 using Xunit;
 
 namespace Steeltoe.Connector.SqlServer.EF6.Test

diff --git a/src/Connectors/test/Connector.EFCore.Test/MySqlDbContextOptionsExtensionsTest.cs b/src/Connectors/test/Connector.EFCore.Test/MySqlDbContextOptionsExtensionsTest.cs
@@ -7,7 +7,6 @@
 using Microsoft.Extensions.DependencyInjection;
 using MySql.Data.MySqlClient;
 using Steeltoe.Connector.EFCore.Test;
-using Steeltoe.Connector.Test;
 using Steeltoe.Extensions.Configuration.CloudFoundry;
 using System;
 using Xunit;

diff --git a/src/Connectors/test/Connector.EFCore.Test/PostgresDbContextOptionsExtensionsTest.cs b/src/Connectors/test/Connector.EFCore.Test/PostgresDbContextOptionsExtensionsTest.cs
@@ -7,7 +7,6 @@
 using Microsoft.Extensions.DependencyInjection;
 using Npgsql;
 using Steeltoe.Connector.EFCore.Test;
-using Steeltoe.Connector.Test;
 using Steeltoe.Extensions.Configuration.CloudFoundry;
 using System;
 using System.Collections.Generic;

diff --git a/src/Connectors/test/Connector.EFCore.Test/SqlServerDbContextOptionsExtensionsTest.cs b/src/Connectors/test/Connector.EFCore.Test/SqlServerDbContextOptionsExtensionsTest.cs
@@ -6,7 +6,6 @@
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Steeltoe.Connector.EFCore.Test;
-using Steeltoe.Connector.Test;
 using Steeltoe.Extensions.Configuration.CloudFoundry;
 using System;
 using System.Data.SqlClient;

diff --git a/src/Connectors/test/ConnectorBase.Test/Relational/MySql/MySqlTypeLocatorTest.cs b/src/Connectors/test/ConnectorBase.Test/Relational/MySql/MySqlTypeLocatorTest.cs
@@ -3,7 +3,6 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
-using System.Linq;
 using Xunit;
 
 namespace Steeltoe.Connector.MySql.Test

diff --git a/src/Connectors/test/ConnectorBase.Test/Services/DB2ServiceInfoFactoryTest.cs b/src/Connectors/test/ConnectorBase.Test/Services/DB2ServiceInfoFactoryTest.cs
@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Steeltoe.Connector.Services;
 using Steeltoe.Extensions.Configuration;
 using Xunit;
 

diff --git a/src/Connectors/test/ConnectorBase.Test/Services/DB2ServiceInfoTest.cs b/src/Connectors/test/ConnectorBase.Test/Services/DB2ServiceInfoTest.cs
@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Steeltoe.Connector.Services;
 using Xunit;
 
 namespace Steeltoe.Connector.Services.Test

diff --git a/src/Connectors/test/ConnectorBase.Test/Services/EurekaServiceInfoFactoryTest.cs b/src/Connectors/test/ConnectorBase.Test/Services/EurekaServiceInfoFactoryTest.cs
@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Steeltoe.Connector.Services;
 using Steeltoe.Extensions.Configuration;
 using Xunit;
 

diff --git a/src/Connectors/test/ConnectorBase.Test/Services/EurekaServiceInfoTest.cs b/src/Connectors/test/ConnectorBase.Test/Services/EurekaServiceInfoTest.cs
@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Steeltoe.Connector.Services;
 using Xunit;
 
 namespace Steeltoe.Connector.Services.Test

diff --git a/src/Connectors/test/ConnectorBase.Test/Services/MongoDbServiceInfoFactoryTest.cs b/src/Connectors/test/ConnectorBase.Test/Services/MongoDbServiceInfoFactoryTest.cs
@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Steeltoe.Connector.Services;
 using Steeltoe.Extensions.Configuration;
 using Xunit;
 

diff --git a/src/Connectors/test/ConnectorBase.Test/Services/MongoDbServiceInfoTest.cs b/src/Connectors/test/ConnectorBase.Test/Services/MongoDbServiceInfoTest.cs
@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Steeltoe.Connector.Services;
 using Xunit;
 
 namespace Steeltoe.Connector.Services.Test

diff --git a/src/Connectors/test/ConnectorBase.Test/Services/MySqlServiceInfoFactoryTest.cs b/src/Connectors/test/ConnectorBase.Test/Services/MySqlServiceInfoFactoryTest.cs
@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Steeltoe.Connector.Services;
 using Steeltoe.Extensions.Configuration;
 using Xunit;
 

diff --git a/src/Connectors/test/ConnectorBase.Test/Services/MySqlServiceInfoTest.cs b/src/Connectors/test/ConnectorBase.Test/Services/MySqlServiceInfoTest.cs
@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Steeltoe.Connector.Services;
 using Xunit;
 
 namespace Steeltoe.Connector.Services.Test

diff --git a/src/Connectors/test/ConnectorBase.Test/Services/OracleServiceInfoFactoryTest.cs b/src/Connectors/test/ConnectorBase.Test/Services/OracleServiceInfoFactoryTest.cs
@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Steeltoe.Connector.Services;
 using Steeltoe.Extensions.Configuration;
 using Xunit;
 

diff --git a/src/Connectors/test/ConnectorBase.Test/Services/OracleServiceInfoTest.cs b/src/Connectors/test/ConnectorBase.Test/Services/OracleServiceInfoTest.cs
@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Steeltoe.Connector.Services;
 using Xunit;
 
 namespace Steeltoe.Connector.Services.Test

diff --git a/src/Connectors/test/ConnectorBase.Test/Services/PostgresServiceInfoFactoryTest.cs b/src/Connectors/test/ConnectorBase.Test/Services/PostgresServiceInfoFactoryTest.cs
@@ -2,7 +2,6 @@
 // The .NET Foundation licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information.
 
-using Steeltoe.Connector.Services;
 using Steeltoe.Extensions.Configuration;
 using Xunit;