Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused imports and refactored imports #145

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

rashidkalwar
Copy link
Contributor

remove the unused imports and tried to make the code a little bit concise.
please review and provide feed back.

@Steffo99 Steffo99 self-requested a review August 3, 2021 02:05
@Steffo99 Steffo99 self-assigned this Aug 3, 2021
@Steffo99 Steffo99 added the feature A request for a new feature. label Aug 3, 2021
@Steffo99 Steffo99 linked an issue Aug 3, 2021 that may be closed by this pull request
Copy link
Owner

@Steffo99 Steffo99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! :D

Usually, when you make a pull request, you try to minimize the amount of changes unrelated to its topic :)

I left you a few suggestions of edits to undo before this pull request can be merged ^_^

.gitignore Outdated Show resolved Hide resolved
core.py Outdated Show resolved Hide resolved
import sys
import time
import sys, time
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing as above :)

Suggested change
import sys
import time
import sys, time
import sys
import time

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply this too :)

worker.py Outdated Show resolved Hide resolved
rashidkalwar and others added 3 commits August 8, 2021 10:42
Co-authored-by: Stefano Pigozzi <ste.pigozzi@gmail.com>
Co-authored-by: Stefano Pigozzi <ste.pigozzi@gmail.com>
Co-authored-by: Stefano Pigozzi <ste.pigozzi@gmail.com>
@rashidkalwar
Copy link
Contributor Author

@Steffo99 I have made commits of your suggestions, please review again.

@Steffo99
Copy link
Owner

Thanks! :D

@Steffo99 Steffo99 merged commit ee86092 into Steffo99:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A request for a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused imports
2 participants