Add Chinese support #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steffo99
reviewed
Aug 22, 2020
There was a problem hiding this comment.
Thanks for the translation pull request!
I feel like the flag emojis better convey the meaning of "language" than the globe emoji (as that emoji is usually used to represent the Internet, instead of a language); I think I'll revert that change during the merge.
I trust that your translation is correct; sadly, I don't know Simplified Chinese at all, so I won't be able to verify it 😅
Be sure to check the comments I added as there might be some things you missed there.
|
Done |
|
Thanks! |
Steffo99
added
lang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that it was not suitable to modify the emoji of the global language, so I also modified it at the same time.
There are still a few questions. I feel that the version information at the beginning of /start affects the experience, and I want to delete it