Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Hebrew language support #70

Merged
merged 4 commits into from
Aug 25, 2020
Merged

Adding Hebrew language support #70

merged 4 commits into from
Aug 25, 2020

Conversation

netanelkoli
Copy link
Contributor

No description provided.

@netanelkoli netanelkoli force-pushed the heb_support branch 2 times, most recently from c4bd86b to 70274f2 Compare August 22, 2020 22:21
@netanelkoli netanelkoli force-pushed the heb_support branch 2 times, most recently from 286992c to 6cd82fc Compare August 22, 2020 22:29
@Steffo99 Steffo99 self-assigned this Aug 22, 2020
@Steffo99 Steffo99 self-requested a review August 22, 2020 22:44
Steffo99
Steffo99 requested changes Aug 24, 2020
View reviewed changes
Copy link
Owner

@Steffo99 Steffo99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Editing RTL text is really difficult for me, as I am not used to it...

Could you please ensure all emojis are on the correct side of the message and they have a space between them and the following text?

@netanelkoli
Copy link
Contributor Author

Did my best, but it looks like one or two emojis just cant be aligned. I added a space between them. Please review.

@Steffo99 Steffo99 self-requested a review August 25, 2020 12:12
Steffo99
Steffo99 approved these changes Aug 25, 2020
View reviewed changes
Copy link
Owner

@Steffo99 Steffo99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks! :D

@Steffo99 Steffo99 merged commit 9267b25 into Steffo99:master Aug 25, 2020
@Steffo99
Copy link
Owner

By the way, you may want to check your git config, your last commit was authored by an email not registered to any GitHub account :)

@Steffo99 Steffo99 added the lang Translation, localization and internationalization. label May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steffo99 Steffo99 Steffo99 approved these changes

Assignees

@Steffo99 Steffo99

Labels
lang Translation, localization and internationalization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@netanelkoli @Steffo99