Western (O. Hlad) copies star names from other cultures

[Atque]

The alternative Western sky culture, O. Hlad, copies the star names of previously selected culture.

To see this, enable a sky culture with very different star names, such as the Belarusian sky culture. Look at Polaris, in Belarusian culture known as "The Nail". Now switch to O. Hlad culture. The name "The Nail" remains instead of "Polaris", as one would suspect. And all other stars have lost their names, and simply show their Bayer designation, Flamsteed number or HIP number.

The reason for this appears to be the lack of a file star_names.fab in the western_hlad folder of the skycultures directory. The other Western varieties do not have this problem, and they do have files called star_names.fab.

A possible solution would be for a sky culture to copy the star names of another culture, in this case the Western sky culture, by a value set in the info.ini, instead of taking it from the previously selected sky culture in the program. So in the info.ini file of the western_hlad folder, a line "star_names = western" could be applied, or something similar. Or perhaps an even better solution, simply copy over the star_names.fab from the default Western culture and place it in the western_hlad folder.

Running on 0.20.2.18060.

[gzotti]

Thanks for the notice. The "O.Hlad" shall represent a very particular implementation of the Western SC. In these "single" skycultures, we cannot simply copy over any other list with names not included in this work. If O.Hlad did not define names, there should be an empty file that provides no names. Or the author shall provide such file.

[Atque]

@alex-w It appears the file star_names.fab is not installed to the folder skycultures/western_hlad. I had to add it manually.

Latest beta, Windows 64-bit.

[alex-w]

Oops... thanks for notification!

[alex-w]

Please check version 0.20.3-4b8e7fd1c8: https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot