Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Jupiter rendering #1261

Closed
luisfl opened this issue Sep 11, 2020 · 13 comments · Fixed by #502
Closed

Wrong Jupiter rendering #1261

luisfl opened this issue Sep 11, 2020 · 13 comments · Fixed by #502
Assignees
@gzotti
Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash state: confirmed A developer can reproduce the issue
Projects
Astronomical calculations (AstroCalc) Solar System
Milestone
0.21.0

Comments

@luisfl
Copy link

luisfl commented Sep 11, 2020 •
edited
Loading

I'm not sure if this is actually a bug, sorry if it is not.

I took some shoots of Jupiter yesterday, and Stellarium showed a wrong rendering of the surface: the Big Red Spot was in the wrong side of the planet.

I am attaching a screenshot of SkyCharts, that agrees with my picture of Jupiter, with the BRS closer to Io than Europa. It seems the image of Jupiter showed by Stellarium is one hour early (yes, the time is correct in Stellarium, set as "System date and time"). Maybe a DST related issue? The images correspond to Sep 10, 2020 22:57 at Rio de Janeiro.

Expected Behaviour

Rendering closer to reality.

Actual Behaviour

This is skychart correct rendering:

skychart_200911112737

This is Stellarium rendering (observe the BRS):

stellarium_200911112831

This is my own picture:

JupiterEuropaIo_EyepieceProjection-9 7mm_JN-200910-B+LX90_47170b

Steps to reproduce

Just zoom at Jupiter at Sep 10, 2020 22:57, Rio de Janeiro.

System

  • Stellarium version: stellarium-0.20.2-1.fc32.x86_64
  • Operating system: Fedora Core 32 fully updated
@github-actions
Copy link

Thanks for adding your first issue to Stellarium. If you have questions, please do not hesitate to contact us.

@alex-w
Copy link
Member

alex-w commented Sep 11, 2020

Please check the longitude of GPS in both programs

@alex-w alex-w added the need more info Read the guidelines how to report properly, or we have new questions/suggestions to try label Sep 11, 2020
@gzotti
Copy link
Member

gzotti commented Sep 11, 2020 •
edited
Loading

You say it may be a DST issue, and name a time 22:57 without giving a decisive detail. What is your exact setting for location, timezone, DST setting? (All on the location panel), and what time zone is given in the status line (lower button bar)?

@luisfl
Copy link
Author

luisfl commented Sep 11, 2020 •
edited
Loading

As I wrote, I am at Rio de Janeiro (UTC -3):
S 22° 57' 13.39"
W 43° 11' 53.97"
Elevation 50m
We are in Winter, so no DST for Rio de Janeiro.

Attaching a screenshot with the status line (I should have done this, sorry).

MyScreenshot_200911_202551

And one our later, the Red Spot is shown in the correct location that it should have been one our before:

MyScreenshot_200911_202959

@gzotti gzotti self-assigned this Sep 12, 2020
@gzotti gzotti added this to the 0.20.4 milestone Sep 12, 2020
@gzotti gzotti added state: confirmed A developer can reproduce the issue importance: medium A bit annoying, minor miscalculation, but no crash and removed need more info Read the guidelines how to report properly, or we have new questions/suggestions to try labels Sep 12, 2020
@gzotti gzotti added this to To Do in Astronomical calculations (AstroCalc) via automation Sep 12, 2020
@gzotti gzotti added this to To Do in Solar System via automation Sep 12, 2020
@alex-w
Copy link
Member

alex-w commented Sep 12, 2020

Please show screenshot of SSO tab

@gzotti
Copy link
Member

gzotti commented Sep 12, 2020

Not a DST error, "1 hour offset" is just by chance. It is really a problem even with correct custom longitude. Probably the position of the GRS in the texture has to be corrected differently, or some multiple of 90° added, I have to figure that out. Compare a few online photos given in the code.

@luisfl
Copy link
Author

luisfl commented Sep 12, 2020

Please show screenshot of SSO tab

MyScreenshot_200912_093520

@gzotti
Copy link
Member

gzotti commented Sep 12, 2020

OK. @luisfl you can use the "Use custom settings of GRS" to adjust GRS longitude. I admit the number is not correct currently. Use something around 260° with today's date, not 340 as would be correct.

@luisfl
Copy link
Author

luisfl commented Sep 12, 2020

OK. @luisfl you can use the "Use custom settings of GRS" to adjust GRS longitude. I admit the number is not correct currently. Use something around 260° with today's date, not 340 as would be correct.

Unless there is something more besides the Jupiter surface rendering, like, e.g., the satellites positions, it is not a serious bug of course, at all. It is a bug of the lowest importance. Just wanted to report it.

@gzotti
Copy link
Member

gzotti commented Sep 12, 2020

Yes, thank you. Still wrong enough to need a fix, although with the workaround, we can "hide" it for a while. I had thought it was fixed 2 years ago, but either something has changed since then, or it worked in 2018 rather by chance but drifted away again? Have to inquire deeper, but better not today.

@alex-w alex-w added the bug Something likely wrong in the code label Sep 14, 2020
@gzotti gzotti modified the milestones: 0.20.4, 0.21.0 Dec 16, 2020
@gzotti gzotti linked a pull request Jan 8, 2021 that will close this issue
improved planet axes #502
Merged
gzotti added a commit that referenced this issue Jan 8, 2021
@gzotti
Fixed Jupiter's GRS rotation. (Fix #1261)
aa46158
Solar System automation moved this from To do to Done Jan 16, 2021
Astronomical calculations (AstroCalc) automation moved this from To do to Done Jan 16, 2021
gzotti added a commit that referenced this issue Jan 16, 2021
@gzotti
improved planet axes (#502)
6bbff61 
* Accurate planet axis orientation and rotation   (Fix #151, Fix #347, Fix #357, Fix #358, Fix #1261, Fix #877, Fix #973)
- Finally finished this long-duration work 2016-21
- Using data from WGCCRE reports 2009, 2015 and Explanatory Supplement to the AA 2013 (with error fixed by the 1992 ed.)
- Keeps original Stellarium planet rotation model (undocumented) where new rotation elements are unavailable
- Slight restructuring of Planets, Comets, MinorPlanets, SolarSystem loader.
- Add lines for the Invariable Plane and Projected Solar Equator
- Add solar altitude to planetary feature nomenclature
- SUG: Describe planetary coordinates and changes in the nomenclature display.
@alex-w alex-w added the state: fixed The bug has been fixed label Jan 17, 2021
@github-actions
Copy link

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: fixed The bug has been fixed label Mar 28, 2021
@github-actions
Copy link

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

@luisfl
Copy link
Author

luisfl commented Apr 1, 2021 •
edited
Loading

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Appimage giving tons of Fontconfig errors, warnings (Fedora 33 fully updated).
I will wait to check the RPMs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzotti gzotti

Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash state: confirmed A developer can reproduce the issue
Projects
Astronomical calculations (AstroCalc)
  
Done
Solar System
  
Done
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

improved planet axes Stellarium/stellarium
3 participants
@alex-w @luisfl @gzotti