Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sat plugin: umbra at "distance" (should be "altitude") does not correspond to selected sat's umbra #3100

Closed
1 of 3 tasks
axd1967 opened this issue Mar 13, 2023 · 8 comments · Fixed by #3538
Closed
1 of 3 tasks
Assignees
Labels
feature Entirely new feature
Milestone

Comments

@axd1967
Copy link
Contributor

axd1967 commented Mar 13, 2023

Expected Behaviour

Actual Behaviour

image
image

Additionally

  • wordings
  • phrasing: "show umbra at distance" should be "show umbra at altitude" (as noted in Earth shadow at sat altitude issues #2510 (comment))
  • phrasing: "show Earth's umbra" should be "show umbra" or "show umbra for selected sat" (idem penumbra) because there is only one "Earth umbra", but each sat has its umbra (depending on altitude)
  • what is meant by "C.U."? -> make it "CU" or "Centre of Umbra"

Steps to reproduce

System

  • Stellarium version: 23.0.72-bdee5b6 [master]

Logfile

If possible, attach the logfile log.txt from your user data directory. Look into the Guide for its location.

@gzotti
Copy link
Member

gzotti commented Mar 13, 2023

This "umbra at fixed distance/altitude" thingy currently seems anyhow not to do the things users would expect, at least not for LEO. We should disable the button and option at least for now. @alex-w ?
C.U. is Center of Umbra, like for Earth's shadow for the Moon.

@alex-w alex-w added this to Needs triage in Plugin: Satellites via automation Mar 14, 2023
@alex-w
Copy link
Member

alex-w commented Mar 14, 2023

This "umbra at fixed distance/altitude" thingy currently seems anyhow not to do the things users would expect, at least not for LEO. We should disable the button and option at least for now. @alex-w ?
C.U. is Center of Umbra, like for Earth's shadow for the Moon.

Ok

@gzotti gzotti self-assigned this Mar 14, 2023
@gzotti gzotti added this to the 23.1 milestone Mar 14, 2023
@alex-w alex-w moved this from Needs triage to To do in Plugin: Satellites Mar 14, 2023
gzotti added a commit that referenced this issue Mar 14, 2023
@gzotti gzotti modified the milestones: 23.1, 23.3 Mar 14, 2023
@gzotti gzotti added the feature Entirely new feature label Mar 14, 2023
@gzotti
Copy link
Member

gzotti commented Mar 14, 2023

Back to the drawing board...

@github-actions
Copy link

Hello @axd1967!

Thank you for suggesting this feature.

@gzotti gzotti removed their assignment Apr 4, 2023
@axd1967
Copy link
Contributor Author

axd1967 commented May 13, 2023

This issue is still open, nevertheless I'd like to add a snippet of observations:

The current ISS marathon is a nice example of what's happening:

image

The ISS orbit is in a momentary blackout (yellow segment, starts in Leo, ends below CrB), but the Earth shadow (drawn red) does not match what Stellarium predicts.

(colors inverted: yellow=visible, red=invisible, time in UTC)
image

Interestingly, Heavens Above does not predict the temporary passage in darkness:

(times in HA screenshot are UTC+2)
(https://heavens-above.com/passdetails.aspx?&satid=25544&mjd=60078.0378598858&type=A)
image

http://www.satflare.com/track.asp?q=25544#TOP does:
image

tracksat.space:

image

@gzotti gzotti modified the milestones: 23.3, 23.4 Sep 11, 2023
@gzotti gzotti self-assigned this Dec 8, 2023
@alex-w alex-w moved this from To do to In progress in Plugin: Satellites Dec 9, 2023
Plugin: Satellites automation moved this from In progress to Done Dec 9, 2023
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Dec 10, 2023
Copy link

Hello @axd1967!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 23, 2023
Copy link

Hello @axd1967!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

@axd1967
Copy link
Contributor Author

axd1967 commented Jan 9, 2024

looking good.
it should be "umbra" rather than "Earth umbra", because it is dependent on the selected satellite or altitude.

I see no reason to make the selected versus virtual sat altitude settings mutually exclusive: two are related to the selected sat, the third is related to the selected altitude value.

image
(Ideally, radio boxes should be employed to convey this desire.)

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Entirely new feature
Projects
Development

Successfully merging a pull request may close this issue.

3 participants