Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing observe list doesn't replace default observe list #3206

Closed
ilkant opened this issue Apr 26, 2023 · 6 comments · Fixed by #3207
Closed

Importing observe list doesn't replace default observe list #3206

ilkant opened this issue Apr 26, 2023 · 6 comments · Fixed by #3207
Assignees
@gzotti
Labels
bug Something likely wrong in the code
Projects
Observing Lists
Milestone
23.3

Comments

@ilkant
Copy link

ilkant commented Apr 26, 2023 •
edited

Expected Behaviour

When you import observe list from computer disk and allow it to overwrite default list, it replaces it.

Actual Behaviour

Imported observe list doesn't replace default list. So you cant see at all imported observe list.

I think that there is other similair behaviors. So may be vice to draw finite automata and design what should be done each case. Default list can be saved default name json and then replaces. So this does not forget default observations.

Imported list might appear to observe window top to drop-down menu. Now it doesn't appear.

Steps to reproduce

  1. Create new observe list
  2. Export it to pisces.json (or what you want)
  3. Quit Stellarium
  4. Start Stellarium
  5. Import pisces.json observe list to Stellarium
  6. Allow pisces.json to overwrite default list
  7. BUG Stellarium does not overwrite default list. So you cant see pisces.json observations at all.

System

  • Stellarium version: <Stellarium 23.1+ 23.1.113-38dbf6a [master]>
  • Operating system: <Kubuntu 23.04>
  • Graphics Card: <MSI GeForce GT 1030/PCIe/SSE2 2GH LF OC, OpenGL 3.3, driver 3.3.0 NVIDIA 515.105.01>
  • Screen type LG 34GK950F 3440x1440

Logfile

log.txt
@alex-w alex-w added this to Needs triage in Observing Lists via automation Apr 26, 2023
@gzotti gzotti self-assigned this Apr 26, 2023
@gzotti gzotti added this to the 23.2 milestone Apr 26, 2023
@gzotti
Copy link
Member

gzotti commented Apr 26, 2023

Seems exported list is malformatted.

@gzotti gzotti added the bug Something likely wrong in the code label Apr 26, 2023
gzotti added a commit that referenced this issue Apr 26, 2023
@gzotti
Fix list export (Fix #3206)
4aceff7
@gzotti gzotti mentioned this issue Apr 26, 2023
Merged
19 tasks
@gzotti gzotti moved this from Needs triage to In progress in Observing Lists Apr 26, 2023
@alex-w alex-w modified the milestones: 23.2, 23.3 Jun 27, 2023
@gzotti gzotti linked a pull request Jul 6, 2023 that will close this issue
Fix observing list import/export #3207
Merged
19 tasks
gzotti added a commit that referenced this issue Sep 11, 2023
@gzotti
Fix list export (Fix #3206)
0576368
gzotti added a commit that referenced this issue Sep 11, 2023
@gzotti
Fix list export (Fix #3206)
e778e98
@gzotti
Copy link
Member

gzotti commented Sep 12, 2023

The point was not anything around default list, but a newly-imported list was not available in the list selection.

Observing Lists automation moved this from In progress to Done Sep 12, 2023
gzotti added a commit that referenced this issue Sep 12, 2023
@gzotti
Fix observing list import/export (#3207)
ff1df3b 
ObsList fixes
- Fix list export (Fix #3206)
- Add last-edited date
- display newly-loaded list (last when loading multiple lists)
- use system time, not simulation time, for list timestamping
- export single .sol and complete .ol lists.
- import single .sol, complete .ol or .json lists.
- SUG: Update about ObsLists
@ilkant
Copy link
Author

ilkant commented Sep 12, 2023

Well done! Now you can save and download lists. Another comment is that it would be good if this announcement could be localized for different languages.
image

@gzotti
Copy link
Member

gzotti commented Sep 13, 2023

Translation is now open to be done on Transifex.

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Sep 18, 2023
@github-actions
Copy link

Hello @ilkant!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 26, 2023
@github-actions
Copy link

Hello @ilkant!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzotti gzotti

Labels
bug Something likely wrong in the code
Projects
Observing Lists
  
Done
Milestone
23.3
Development

Successfully merging a pull request may close this issue.

Fix observing list import/export Stellarium/stellarium
3 participants
@alex-w @gzotti @ilkant