-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible bugs in LX200 protocol implementation #818
Comments
Feedback: https://astronomy.ru/forum/index.php?topic=21983.msg4908237#msg4908237 Not working the RA axis P.S. False positive - it was DIY project with implementation the LX200 protocol for communication for Stellarium. |
It seems to me that a bug has been introduced with this issue. When I try to control my MEADE LX200GPS with Stellarium, I get the following error message Connection::performWriting: writeNonblocking(5) returned 5; #:GD# If #:GD# is sent directly to the telescope via the serial interface, it responds with 0xDF (DEC 223) for the degree sign, e.g.: ASCII: +51ß14:20# This also seems to be the expected behavior, see https://www.skymtn.com/mapug-astronomy/ragreiner/LX200Commands.html Therefore, from my point of view, the character DEC 223 / HEX 0xDF must be checked for, not '*'. |
@toweosp Whoa, finally somebody competent to test this with a real instrument, many thanks. That means the asterisk published everywhere in the protocol specs is really just a print replacement because they cannot print 0xDF themselves? I just wonder why this is the only character in the protocol that is invalid according to the compiler. Maybe we can change the data type to unsigned char to avoid compiler warnings. |
I also wonder why Meade removed the grammar info when they revised their website for the LX200 protocol (see archive on https://www.astro.louisville.edu/software/xmtel/archive/xmtel-indi-6.0/xmtel-6.0l/support/lx200/CommandSet.html#LX200CmdSetGrammar), since there is no information on this in the PDF that you can download from the Meade website today. |
This change also removed one of two spaces. @toweosp Do you have insight whether these spaces are indeed correct, i.e. should I revert this as well? |
Hello @gzotti! Please check the fresh version (development snapshot) of Stellarium: |
I re-open just to let @toweosp check this fix. |
@toweosp please can you compile and test this fix? |
@gzotti Connection::performWriting: writeNonblocking(5) returned 5; #:GD# Regarding the #:Sr23:00:00# #:Sr 23:00:00# #:Sr-----23:00:00# #:Srasdfasf# #:Sr# I was not able to provoke the return value 0 (invalid). I have not checked the :Sd command yet. p.s.: By chance I had found this: |
You mean these lower test were with some serial terminal (putty?), without Stellarium? Interesting. I'd just have needed an LX200. Thank you for sharing this protocol. It seems even bogus values do "something", successfully, and only not setting anything (electrical problem, or failure in reading back any value?) would return 0? Then we should also test for result 100, and do something with it. (Ignore&retry?) It seems this documentation bug (* vs. °) on Meade's side has confused several people... If one space more or less is harmless, we shall keep one space. But please test whether anything is still broken. We should finally have a fix for this family. |
@toweosp any news? |
@alex-w @gzotti As written in my last post the control of the telescope - especially detection of the DEC position - is working now. This was tested by controlling my telescope with stellarium in a "dry run" in my cellar doing a blind initial alignment of the telescope. The additional checks regarding the |
Thank you for testing these things. We hope this is finally done and circumstances documented now. |
Hello @gzotti! Please check the latest stable version of Stellarium: |
'*' = char ASCII 42 |
@giuse320 what do you want to say with this comment? |
It seems there should be a few problems in the LX200 commands:
However, I cannot test this as I have no compatible instrument. I will push a tentative fix for the next beta, and we should ask users for response.
The text was updated successfully, but these errors were encountered: