Navstar Sun limb size and direction fix #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic correction for +/- direction
axd1967
reviewed
Nov 9, 2021
| double obj_radius_in_degrees = selectedObject->getAngularSize(core); | ||
| if (!upperLimb) | ||
| obj_radius_in_degrees *= -1; | ||
| calc.addAltAppRad((obj_radius_in_degrees * M_PI) / 180.); |
There was a problem hiding this comment.
@A-j-K congratulations for using expressive variable names! and I love your copious use of whitespace (see higher in the code).
|
Hello @A-j-K! Please check the fresh version (development snapshot) of Stellarium: |
|
Hello @A-j-K! Please check the latest stable version of Stellarium: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use actual radius as returned and not assumed diameter. Also a bool logic correction for +/- direction
Description
The value of Ho as displayed in the extrainfo panel was incorrect and failed to match other tools such as the Pointing Tool or AltAz grid.
Fixes reported issue #2019
As patch;
selectedObject->getAngularSize(core); returns radius not diameter
Logic on upperLimb was inverted.
n/a
None.
Fixes # (issue)
#2019
Type of change
How Has This Been Tested?
Created new test scripts that setup Stellarium with place, date and time as reported in issue 2019.
Observed fault.
Fixed.
Run script again and observed correct.
Also created script for Northern hemisphere to double check the fix (the report was for a location in the Southern hemisphere but was broke in both).
n/a
n/a
Checklist: