New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added recognition licenses for sky cultures #2410
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
This is an automatically generated QA checklist based on modified files |
Hello @alex-w! Thank you for this enhancement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These entries make sense esp. when a check is done before packing. Useful test:
- check for existence of this entry
- check for particular license keywords (check validity of this entry)
Formally, git does not like the missing newline. This must be fixed before merge.
The manager of sky cultures is the next obvious task :) Probably also with adding the script for manage packaging sky cultures into main package and separate packages for each "non-free" sky culture.
Fixed! |
@gzotti please review this pull request |
Oops, on Sunday, OK. |
@sushoff please review this pull request |
yes, I agree - thank you for this PR |
Add license declaration (Thanks Javier!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we are complete.
Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium: |
Added code to recognition the license (or licenses) info in sky cultures and show human readable hints for granted permissions for users. A few sky cultures have an updated license info in info.ini file. Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
Hello @alex-w! Please check the latest stable version of Stellarium: |
Description
Added code to recognition the license (or licenses) info in sky cultures and show human readable hints for granted permissions for users. A few sky cultures have an updated license info in
info.ini
file.Sub-tasks:
info.ini
file into Stellarium User Guidedescription.en.utf8
files) of sky culturesType of change
Checklist: