Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recognition licenses for sky cultures #2410

Merged
merged 14 commits into from May 26, 2022
Merged

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Apr 20, 2022

Description

Added code to recognition the license (or licenses) info in sky cultures and show human readable hints for granted permissions for users. A few sky cultures have an updated license info in info.ini file.

Sub-tasks:

  • Add information about requirement data for info.ini file into Stellarium User Guide
  • Add license info into info.ini file for all sky cultures (all known)
  • Removing the license info from descriptions (see description.en.utf8 files) of sky cultures

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot requested a review from gzotti April 20, 2022 11:39
@alex-w alex-w added this to To do in Sky Cultures via automation Apr 20, 2022
@alex-w alex-w requested a review from sushoff April 20, 2022 11:39
@github-actions
Copy link

github-actions bot commented Apr 20, 2022

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

Files matching skycultures/**:

  • Did you remember to update po/stellarium-skycultures/POFILES.in file respectively to changes in sky cultures?
  • Did you remember to update skycultures/CMakeLists.txt and skycultures/YOUR-SKYCULTURE-FOLDER/CMakeLists.txt files respectively to changes in sky cultures?
  • Did you remember to update util/skycultures/po4a.config file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures?

This is an automatically generated QA checklist based on modified files

@alex-w alex-w moved this from To do to In progress in Sky Cultures Apr 20, 2022
@alex-w alex-w added enhancement Improve existing functionality data Missing/bad/outdated data, but no code error labels Apr 20, 2022
@alex-w alex-w added this to the 0.22.2 milestone Apr 20, 2022
@github-actions
Copy link

Hello @alex-w! Thank you for this enhancement.

Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These entries make sense esp. when a check is done before packing. Useful test:

  • check for existence of this entry
  • check for particular license keywords (check validity of this entry)

Formally, git does not like the missing newline. This must be fixed before merge.

@alex-w
Copy link
Member Author

alex-w commented Apr 20, 2022

These entries make sense esp. when a check is done before packing. Useful test:

  • check for existence of this entry
  • check for particular license keywords (check validity of this entry)

The manager of sky cultures is the next obvious task :) Probably also with adding the script for manage packaging sky cultures into main package and separate packages for each "non-free" sky culture.

Formally, git does not like the missing newline. This must be fixed before merge.

Fixed!

@alex-w alex-w requested a review from gzotti April 21, 2022 01:35
@alex-w
Copy link
Member Author

alex-w commented May 20, 2022

@gzotti please review this pull request

@gzotti
Copy link
Member

gzotti commented May 20, 2022

@gzotti please review this pull request

Oops, on Sunday, OK.

skycultures/anutan/info.ini Outdated Show resolved Hide resolved
skycultures/maya/info.ini Outdated Show resolved Hide resolved
@alex-w
Copy link
Member Author

alex-w commented May 22, 2022

@sushoff please review this pull request

@sushoff
Copy link
Contributor

sushoff commented May 22, 2022

yes, I agree - thank you for this PR

Add license declaration (Thanks Javier!)
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we are complete.

@alex-w alex-w merged commit 25f6b0d into master May 26, 2022
Sky Cultures automation moved this from In progress to Done May 26, 2022
@alex-w alex-w deleted the skyculture/license-info branch May 26, 2022 20:01
@alex-w alex-w added the state: fixed The bug has been fixed label May 29, 2022
@github-actions
Copy link

Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

gzotti added a commit that referenced this pull request Jun 8, 2022
Added code to recognition the license (or licenses) info in sky cultures and show human readable hints for granted permissions for users. A few sky cultures have an updated license info in info.ini file.

Co-authored-by: Georg Zotti <Georg.Zotti@univie.ac.at>
@alex-w alex-w removed the state: fixed The bug has been fixed label Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Hello @alex-w! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Missing/bad/outdated data, but no code error enhancement Improve existing functionality
Projects
Sky Cultures
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants