Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken signal/slot in Meteor Showers plugin #2433

Merged
merged 3 commits into from May 6, 2022
Merged

Fix broken signal/slot in Meteor Showers plugin #2433

merged 3 commits into from May 6, 2022

Conversation

worachate001
Copy link
Member

Description

Fixes #2428

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: Ubuntu 20.04
  • Graphics Card: Nvidia Geforce RTX

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot requested review from alex-w and gzotti May 5, 2022 06:08
@alex-w alex-w added this to To do in Plugin via automation May 5, 2022
@alex-w alex-w added this to the 0.22.2 milestone May 5, 2022
@worachate001 worachate001 requested review from gzotti and alex-w May 5, 2022 23:33
Plugin automation moved this from To do to In progress May 6, 2022
@alex-w alex-w merged commit 8678602 into Stellarium:master May 6, 2022
Plugin automation moved this from In progress to Done May 6, 2022
@worachate001 worachate001 deleted the fix-meteorshowers branch May 6, 2022 04:48
@alex-w alex-w added the state: fixed The bug has been fixed label May 22, 2022
@github-actions
Copy link

Hello @worachate001! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: fixed The bug has been fixed label Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Hello @worachate001! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Plugin
  
Done
Development

Successfully merging this pull request may close these issues.

Downloading meteor showers
3 participants