Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a new Stellarium Sky Culture: Samoan #2627

Merged
merged 17 commits into from
Sep 5, 2022
Merged

Adding a new Stellarium Sky Culture: Samoan #2627

merged 17 commits into from
Sep 5, 2022

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Sep 4, 2022

Description

A new Stellarium Sky Culture - Samoan - from Jake Fitisemanu and Dan Smale with small changes from me to respect latest changes in the code of SC support.

Type of change

  • New feature (non-breaking change which adds functionality)

alex-w and others added 6 commits August 30, 2022 16:45
@alex-w
Adding a new Stellarium Sky Culture: Samoan (Initian commit)
1f72e6f 
Co-authored-by: Jake Fitisemanu Jr.<jjfitisemanu@gmail.com>
Co-authored-by: Dan Smale <Dan.Smale@niwa.co.nz>
@alex-w
Added license and author info into info.ini file
0639e58 
Co-authored-by: Jake Fitisemanu Jr. <jjfitisemanu@gmail.com>
Co-authored-by: Dan Smale <Dan.Smale@niwa.co.nz>
@alex-w
Cosmetic changes due latest code changes
77e44b0
@alex-w
added cmake file
5c7db87
@alex-w
fix cmake script
ede9817
@alex-w
formatting fix
096e3cb
@alex-w alex-w added the data Missing/bad/outdated data, but no code error label Sep 4, 2022
@alex-w alex-w added this to Needs triage in Sky Cultures via automation Sep 4, 2022
@alex-w alex-w added this to the 1.0 milestone Sep 4, 2022
@github-actions
Copy link

github-actions bot commented Sep 4, 2022 •
edited by alex-w
Loading

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

  • Did you remember to update po/stellarium-skycultures/POFILES.in file respectively to changes in sky cultures?
  • Did you remember to update skycultures/CMakeLists.txt and skycultures/YOUR-SKYCULTURE-FOLDER/CMakeLists.txt files respectively to changes in sky cultures?
  • Did you remember to update util/skycultures/po4a.config file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures (see info.ini file)?
  • Did you remember to define license parameter in sky cultures (see info.ini file)?

This is an automatically generated QA checklist based on modified files

@alex-w alex-w moved this from Needs triage to To do in Sky Cultures Sep 4, 2022
alex-w and others added 3 commits September 5, 2022 14:19
@alex-w
ol -~> dl
41e2aa2
@sushoff
pointing out the nature of this work
714852f 
after many requests in the past few years, I now state this at the beginning of the text
@sushoff
pointing out the nature of the work
a307148 
see English
@alex-w alex-w moved this from To do to In progress in Sky Cultures Sep 5, 2022
@sushoff
pointing out the nature of the work
cecec70 
see English
@sushoff
pointing out the nature of the work
9894c66 
see English
@sushoff
pointing out the nature of the work
5ca55cb 
see English
@sushoff
pointing out the nature of the work
22a7c10 
see English
@sushoff
pointing out the nature of the work
0dc9ec3 
see English
@sushoff
pointing out the nature of the work
56e16b9 
see English - the first paragraph was not translated here
@sushoff
pointing out the nature of the work
ba7059c 
see English - the first paragraph is not yet translated
@sushoff
pointing out the nature of the work
61746b6 
some paragraphs not yet translated
@alex-w alex-w requested a review from gzotti September 5, 2022 09:40
gzotti
gzotti approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sushoff please next time, try to stick to editing files only in the PR (or branch) in question, so we have a less convoluted history.

@alex-w alex-w merged commit 4071538 into master Sep 5, 2022
Sky Cultures automation moved this from In progress to Done Sep 5, 2022
@alex-w alex-w deleted the skyculture/samoan branch September 5, 2022 19:39
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Sep 10, 2022
@github-actions
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Oct 1, 2022
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzotti gzotti gzotti approved these changes

@sushoff sushoff Awaiting requested review from sushoff

Assignees

@alex-w alex-w

Labels
data Missing/bad/outdated data, but no code error
Projects
Sky Cultures
  
Done
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alex-w @gzotti @sushoff