Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the rest of the codebase #2862

Merged
merged 3 commits into from
Dec 11, 2022
Merged

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Nov 20, 2022

Description

Fix typos in the rest of the codebase
Follow up to:
21cfcec
5d359a8

Found via codespell -q 3 -S *.po,*.pot,*.utf8,ChangeLog,./src/external,./plugins/RemoteControl/webroot/js -L anonymus,bu,ded,dout,eyt,fiter,inout,lod,maka,mane,nd,ned,previousy,regio,sav,ser,serie,som,statics,te,tht,ue,unter

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housecleaning

How Has This Been Tested?

n/a

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

Files matching skycultures/**:

  • Did you remember to update po/stellarium-skycultures/POFILES.in file respectively to changes in sky cultures?
  • Did you remember to update skycultures/CMakeLists.txt and skycultures/YOUR-SKYCULTURE-FOLDER/CMakeLists.txt files respectively to changes in sky cultures?
  • Did you remember to update util/skycultures/po4a.config file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures (see info.ini file)?
  • Did you remember to define license parameter in sky cultures (see info.ini file)?
  • Did you remember to define region paramater in sky culture (see info.ini file)?

This is an automatically generated QA checklist based on modified files

CREDITS.md Outdated Show resolved Hide resolved
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, almost done. I had a few of these on my radar, thanks for collecting them!

@alex-w alex-w added this to the 1.2 milestone Nov 22, 2022
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luzpaz please resolve finded issues

@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 27, 2022

Will do so this week

luz paz added 2 commits November 28, 2022 18:39
Found via `codespell -q 3 -S *.po,*.pot,*.utf8,ChangeLog,./src/external,./plugins/RemoteControl/webroot/js -L anonymus,bu,ded,dout,eyt,fiter,inout,lod,maka,mane,nd,ned,previousy,regio,sav,ser,serie,som,statics,te,tht,ue,unter`
@luzpaz
Copy link
Contributor Author

luzpaz commented Nov 29, 2022

Apologies, should be fixed in bb8bd66

@alex-w alex-w merged commit 9e96022 into Stellarium:master Dec 11, 2022
@luzpaz luzpaz deleted the typos/misc branch December 11, 2022 10:10
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Dec 12, 2022
@github-actions
Copy link

Hello @luzpaz!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 25, 2022
@github-actions
Copy link

Hello @luzpaz!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

luzpaz added a commit to luzpaz/stellarium that referenced this pull request Sep 15, 2023
@luzpaz luzpaz mentioned this pull request Sep 15, 2023
14 tasks
gzotti pushed a commit that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants