Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing include #2933

Merged
merged 1 commit into from Dec 26, 2022
Merged

add missing include #2933

merged 1 commit into from Dec 26, 2022

Conversation

bkuhls
Copy link
Contributor

@bkuhls bkuhls commented Dec 25, 2022

Description

Fixes build error with qt5:

stellarium-1.2/plugins/MeteorShowers/src/MeteorShowersMgr.hpp:331:12:
error: field 'm_lastUpdate' has incomplete type 'QDateTime'

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • My changes generate no new warnings

github-actions[bot]
github-actions bot reviewed Dec 25, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding your first pull request to Stellarium. If you have questions, please do not hesitate to contact us.

@alex-w
Copy link
Member

alex-w commented Dec 25, 2022

@bkuhls which operating system is used for building?

@alex-w alex-w added this to Needs triage in Plugin via automation Dec 25, 2022
@alex-w alex-w added this to the 23.1 milestone Dec 25, 2022
@bkuhls
Copy link
Contributor Author

bkuhls commented Dec 25, 2022

@bkuhls which operating system is used for building?

-- The C compiler identification is GNU 10.3.0
-- The CXX compiler identification is GNU 10.3.0
-- Platform: Linux (x86_64)

@alex-w
Copy link
Member

alex-w commented Dec 25, 2022 •
edited

@bkuhls which operating system is used for building?

-- The C compiler identification is GNU 10.3.0
-- The CXX compiler identification is GNU 10.3.0
-- Platform: Linux (x86_64)

Thanks! Please share uname -a also

Plugin automation moved this from Needs triage to In progress Dec 25, 2022
@bkuhls
Copy link
Contributor Author

bkuhls commented Dec 25, 2022

@bkuhls which operating system is used for building?

-- The C compiler identification is GNU 10.3.0
-- The CXX compiler identification is GNU 10.3.0
-- Platform: Linux (x86_64)

Thanks! Please share uname -a also

$ uname -a
Linux pc 6.1.1-x64v3-xanmod1 #0~20221222.0006b63 SMP PREEMPT_DYNAMIC Thu Dec 22 01:48:58 UTC  x86_64 GNU/Linux

The build error occured during cross-compilation with a musl-based toolchain while updating
the stellarium package https://git.busybox.net/buildroot/tree/package/stellarium in buildroot.
This is the qt5 revision used: https://git.busybox.net/buildroot/tree/package/qt5/qt5base/qt5base.mk#n7

@gzotti
Copy link
Member

gzotti commented Dec 25, 2022

Do I understand "Stellarium for Busybox"? Emergency stick? ;-) Or for your router? Interested to read such user stories...

@bkuhls
add missing include
47f7319 
Fixes build error with qt5 on Linux:

stellarium-1.2/plugins/MeteorShowers/src/MeteorShowersMgr.hpp:331:12:
 error: field 'm_lastUpdate' has incomplete type 'QDateTime'
gzotti
gzotti approved these changes Dec 25, 2022
View reviewed changes
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me, thanks.

@alex-w alex-w merged commit e860c31 into Stellarium:master Dec 26, 2022
Plugin automation moved this from In progress to Done Dec 26, 2022
@bkuhls bkuhls deleted the fix_MeteorShowers branch December 26, 2022 08:18
@alex-w alex-w added the state: fixed The bug has been fixed label Mar 12, 2023
@github-actions
Copy link

Hello @bkuhls!

The fix has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@alex-w alex-w added state: published The fix has been published for testing in weekly binary package and removed state: fixed The bug has been fixed labels Mar 13, 2023
@github-actions
Copy link

Hello @bkuhls!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@alex-w alex-w alex-w approved these changes

@gzotti gzotti gzotti approved these changes

@10110111 10110111 Awaiting requested review from 10110111

Assignees

@bkuhls bkuhls

Labels
None yet
Projects
Plugin
  
Done
Milestone
23.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkuhls @alex-w @gzotti