Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that textures being loaded don't exceed OpenGL size limits #2991

Merged
merged 1 commit into from Jan 20, 2023
Merged

Make sure that textures being loaded don't exceed OpenGL size limits #2991

merged 1 commit into from Jan 20, 2023

Conversation

10110111
Copy link
Contributor

This commit should fix the problem of untextured Moon on Raspberry Pi or other devices with small maximum texture size. I did check that it works by simulating a 2048px maximum, but didn't check on actual Raspberry Pi, which @gzotti said suffers from this problem.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: Ubuntu 20.04
  • Graphics Card: Intel UHD Graphics 620

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w added this to Needs triage in OpenGL/GLSL via automation Jan 14, 2023
@alex-w alex-w added this to Needs triage in Hardware: ARM via automation Jan 14, 2023
@alex-w alex-w added this to the 23.1 milestone Jan 14, 2023
@alex-w alex-w removed their request for review January 14, 2023 14:30
@github-actions github-actions bot added the has conflicts The pull request has conflicts label Jan 20, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the has conflicts The pull request has conflicts label Jan 20, 2023
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

gzotti
gzotti reviewed Jan 20, 2023
View reviewed changes
src/core/StelTexture.cpp Outdated Show resolved Hide resolved
gzotti
gzotti approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested on my RasPi3. Works. Thank you very much.
The only change I suggest is about the warning notice, see below.

OpenGL/GLSL automation moved this from Needs triage to In progress Jan 20, 2023
Hardware: ARM automation moved this from Needs triage to In progress Jan 20, 2023
@gzotti gzotti merged commit 183fedc into Stellarium:master Jan 20, 2023
OpenGL/GLSL automation moved this from In progress to Done Jan 20, 2023
Hardware: ARM automation moved this from In progress to Done Jan 20, 2023
@10110111 10110111 deleted the resize-large-textures branch February 25, 2023 09:58
@alex-w alex-w added the state: fixed The bug has been fixed label Mar 12, 2023
@github-actions
Copy link

Hello @10110111!

The fix has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@alex-w alex-w added state: published The fix has been published for testing in weekly binary package and removed state: fixed The bug has been fixed labels Mar 13, 2023
@github-actions
Copy link

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 27, 2023
@github-actions
Copy link

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzotti gzotti gzotti approved these changes

Assignees

@10110111 10110111

Labels
None yet
Projects
Hardware: ARM
  
Done
OpenGL/GLSL
  
Done
Milestone
23.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@10110111 @gzotti @alex-w