Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support 32-wind compass rose #3036

Merged
merged 5 commits into from
Feb 3, 2023
Merged

Added support 32-wind compass rose #3036

merged 5 commits into from
Feb 3, 2023

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Feb 1, 2023

Description

Currently we have support 8-wind and 16-wind compass rose (used in navigation and meteorology). I've added support 32-wind compass rose as an additional to Navigational Stars plugin for navigational purpose.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

  1. Run Stellarium
  2. Enable cardinal points
  3. Enable 8-, 16- and 32-wind compass rose

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w alex-w added this to Needs triage in Visualization via automation Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@10110111
Copy link
Contributor

10110111 commented Feb 1, 2023

Is it actually useful? I do realize that these names exist, but IMHO at some point naming ever smaller sectors becomes more cumbersome than simply using numeric azimuth.

@gzotti
Copy link
Member

gzotti commented Feb 1, 2023

1/32 of the full circle is an (outdated?) nautical directional unit ("Strich" in German; sorry, I cannot find an English reference for this! Google translate has "dash". A similar concept with smaller units is the artilleristic 'mil' (6400 parts to the circle, or 6000 in former Soviet-influenced states). There are nautical commands like "Ruder zwei Strich backbord" (Turn rudder to change course by two of these 1/32 units to the left"). So yes, this is the last partition that may make sense. Maybe even extend this in yet another option to not use these names but show all these directions with the proper unit sign like 16" for "due south".

@alex-w
Copy link
Member Author

alex-w commented Feb 1, 2023

Is it actually useful? I do realize that these names exist, but IMHO at some point naming ever smaller sectors becomes more cumbersome than simply using numeric azimuth.

Yes, but for navigational purposes and partially for marine astronomy. By default these labels are disabled and probably for low count of users this feature will be extra useful (sailors), but this is final part for standard marine/navigational compass points, so, all navigational data is complete now.

@alex-w
Copy link
Member Author

alex-w commented Feb 1, 2023

1/32 of the full circle is an (outdated?) nautical directional unit ("Strich" in German; sorry, I cannot find an English reference for this! Google translate has "dash". A similar concept with smaller units is the artilleristic 'mil' (6400 parts to the circle, or 6000 in former Soviet-influenced states). There are nautical commands like "Ruder zwei Strich backbord" (Turn rudder to change course by two of these 1/32 units to the left"). So yes, this is the last partition that may make sense. Maybe even extend this in yet another option to not use these names but show all these directions with the proper unit sign like 16" for "due south".

Russian: румб :) These directions still uses by sailors for example.

@gzotti
Copy link
Member

gzotti commented Feb 1, 2023

Russian: румб :) These directions still uses by sailors for example.

Ah, that brought me to the English term: https://en.wikipedia.org/wiki/Rhumb

src/gui/ViewDialog.cpp Outdated Show resolved Hide resolved
@alex-w alex-w added this to the 23.1 milestone Feb 2, 2023
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me.

Visualization automation moved this from Needs triage to In progress Feb 3, 2023
@alex-w alex-w merged commit 492c896 into master Feb 3, 2023
Visualization automation moved this from In progress to Done Feb 3, 2023
@alex-w alex-w deleted the 32-wind branch February 3, 2023 18:29
@alex-w alex-w added the state: implemented The enhancement or feature has been implemented label Mar 12, 2023
@github-actions
Copy link

Hello @alex-w!

The enhancement or feature has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@alex-w alex-w added the state: fixed The bug has been fixed label Mar 12, 2023
@github-actions
Copy link

Hello @alex-w!

The fix has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@alex-w alex-w added state: published The fix has been published for testing in weekly binary package and removed state: fixed The bug has been fixed labels Mar 13, 2023
@alex-w alex-w removed the state: implemented The enhancement or feature has been implemented label Mar 13, 2023
@github-actions
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 27, 2023
@github-actions
Copy link

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Visualization
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants