Use config settings screen_* in physical (unscaled) pixels

[10110111]

Description

This makes the config settings screen_{w,h,x,y} work as defined in units of real pixels—the only sensible user-visible units for any screen. Previously, due to the Qt approach to GUI scaling, these settings were stored and read in units of virtual pixels.

I hope this change will relieve the debates about PR #3071.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• This change requires a documentation update

How Has This Been Tested?

Test Configuration:

• Operating system: Ubuntu 20.04
• Graphics Card: Intel UHD Graphics 620

Checklist:

• My code follows the code style of this project.
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (header file)
• I have updated the respective chapter in the Stellarium User Guide
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

• Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

[alex-w]

Thanks!

[alex-w]

Tested on macOS - everything OK

[gzotti]

This again scales the custom-sized screenshots.

Is this thought as precondition for #3071?

[10110111]

Is this thought as precondition for #3071?

Yes, this doesn't affect screenshot sizes.

[gzotti]

It actually does. Screenshot from Fullscreen has screen pixel count, from windowed mode has configured pixel count from config.ini, but custom-size screenshot deviates from configured size. If this is fixed in #3071, we can continue discussion there after merge of this.

[10110111]

This commit only affects the correspondence between config.ini and window size. Custom-sized screenshots remain at status quo, i.e. broken. This is fixed in #3071.

[github-actions]

Hello @10110111!

The enhancement or feature has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

[github-actions]

Hello @10110111!

The fix has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

[github-actions]

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

[github-actions]

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest