Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AstroCalc: show current location of object #3289

Merged
merged 2 commits into from Jul 9, 2023
Merged

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Jun 28, 2023

Description

This pull request adds the ability to show current locations of objects which already have computed ephemeris.

Fixes #2937 (issue)

Screenshots (if appropriate):

stellarium-007

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

  • Run Stellarium
  • Open AstroCalc/Ephemeris tool and compute ephemeris
  • Open "Extra options..." windows and mark "Show marker for current location"
  • See the screen

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot requested review from 10110111 and gzotti June 28, 2023 09:09
@alex-w alex-w added this to Needs triage in Astronomical calculations (AstroCalc) via automation Jun 28, 2023
@alex-w alex-w added this to the 23.3 milestone Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w moved this from Needs triage to To do in Astronomical calculations (AstroCalc) Jun 28, 2023
@alex-w alex-w merged commit 9e6e186 into master Jul 9, 2023
19 checks passed
Astronomical calculations (AstroCalc) automation moved this from To do to Done Jul 9, 2023
@alex-w alex-w deleted the astrocalc/ephemeris-now branch July 9, 2023 15:48
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Jul 15, 2023
@github-actions
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 26, 2023
@github-actions
Copy link

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

astronomical calc: show current object
1 participant