Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support transparency for landscapes #3293

Merged
merged 6 commits into from Jul 2, 2023

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Jun 30, 2023

Description

This pull request added support the transparency for landscapes.

Fixes #3214 (issue)

Previous solution is #3288

Screenshots (if appropriate):

stellarium-005
stellarium-006

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot requested review from 10110111 and gzotti June 30, 2023 10:42
@alex-w alex-w added this to Needs triage in Landscapes via automation Jun 30, 2023
@alex-w alex-w added this to Needs triage in Visualization via automation Jun 30, 2023
@alex-w alex-w added this to the 23.3 milestone Jun 30, 2023
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@gzotti
Copy link
Member

gzotti commented Jun 30, 2023

Can you please explain the difference between this and the already reviewed working solution #3288 ? Why a new PR?

@alex-w
Copy link
Member Author

alex-w commented Jul 1, 2023

Can you please explain the difference between this and the already reviewed working solution #3288 ? Why a new PR?

I renamed the branch to reflect logic of work and old PR was automatically closed.

Visualization automation moved this from Needs triage to In progress Jul 1, 2023
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me! The polygonal still looks bad in a few projections, but with the shader-based solution in the other landscapes this finally looks useful.

Landscapes automation moved this from Needs triage to In progress Jul 1, 2023
@alex-w alex-w merged commit 5e14e82 into master Jul 2, 2023
19 checks passed
Visualization automation moved this from In progress to Done Jul 2, 2023
@alex-w alex-w deleted the feature/transparent-landscapes branch July 2, 2023 12:18
Landscapes automation moved this from In progress to Done Jul 2, 2023
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 26, 2023
@github-actions
Copy link

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Landscapes
  
Done
Visualization
  
Done
Development

Successfully merging this pull request may close these issues.

Allow opacity setting for ground_color in polygonal landscapes
2 participants