Modernize Mesa library #3414

gzotti · 2023-09-16T01:17:52Z

Retry of #3409

Description

This is intended to fix problems around outdated Mesa V11 libraries which come with Qt.
It provides OpenGL 4.5 CoreProfile and would allow to run advanced features (OpenGL3.3) on really old systems,
or in some circumstances where Stellarium needs to run in a VM without GPU.

A first way is replacing the default opengl32sw.dll by another build of Mesa 20 from https://fdossena.com/?p=mesa/index.frag

Further, if users prefer, prepare program for user upgrade with current Mesa3D builds, and add instructions to SUG.

This also finally removes the deprecated "safe mode" CLI switch.

Fixes #2803

Screenshots (if appropriate):

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
This change requires a documentation update
Housekeeping

How Has This Been Tested?

Test Configuration:

Operating system: Windows 11
Graphics Card: Geforce 3070Ti (but this explicitly runs on CPU!)
CPU: Intel Core i7-12700.

Checklist:

My code follows the code style of this project.
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (header file)
I have updated the respective chapter in the Stellarium User Guide
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

github-actions · 2023-09-16T01:18:40Z

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

Are possibly unused includes removed?

Files matching guide/**:

Did you remember to update screenshots to match new updates?
Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files.

alex-w · 2023-09-16T06:34:10Z

I see no changes in .appveyor.yml file

10110111 · 2023-09-16T06:43:54Z

guide/ch_advanced_use.tex

+Rendering the graphics without hardware acceleration is of course much slower than accelerated graphics, but it's surely better than nothing.
+
+Qt's default Mesa library (Mesa 11) provides support for OpenGL~3.0 only. This prevents users of Qt5-based versions from applying dithering. 
+On Qt6, also the \program{ShowMySky} skylight model (see section~\ref{sec:skylight:ShowMySky}) is then not available. 


ShowMySky doesn't depend on Qt version.

ShowMySky is now available on Qt6 builds only, right?

No, Qt version doesn't make any difference.

BTW, dithering also doesn't depend on Qt version.

OK. I remember we had discussed removing SMS from Qt5 builds as those are intended for incapable systems only. Good!

Does dithering depend on the availability of OpenGL3.3 or not? If it does, then users of Qt5/Mesa11(OpenGL3.0) cannot apply dithering. This was written in light of SMS not available, so the only OpenGL issue to mention would have been missing dithering.

The only factor that affects availability of high graphics mode is support for OpenGL 3.3. After all the discussions I decided to not take Qt version into account, because it wouldn't simplify anything.

High graphics mode currently defines whether we have dithering and ShowMySky.

10110111 · 2023-09-16T06:48:26Z

guide/ch_advanced_use.tex

+The \program{Mesa3D} project \footnote{\url{https://www.mesa3d.org/}} meanwhile (2023) provides at least OpenGL~4.5. 
+If you wish to use more ``up to date'' precompiled binaries and have Administrator privileges on your Windows system, \newFeature{23.3}
+you can replace this library using the following steps to install inofficial builds\footnote{\url{https://github.com/pal1000/mesa-dist-win/}}. 
+Note however that after this upgrade, the program runs with considerably ($\approx$35\%?) lower framerate. 


Didn't you say this improves frame rate rather than degrades?

This branch should

replace Qt's Mesa 11 by fdossena's Mesa 20. Unconditionally.

For "purists" who don't like taking Mesa DLLs from other sources than github, describe a path to move to a "more official" Mesa build, which however runs considerably slower. Just like giving instructions to run nouveau drivers for OS purists.

(2) is done. The next steps will hopefully bring the Mesa20 DLL to where it belongs.

(2) makes zero sense, because pal1000's builds are not more official than fdossena's ones. Both provide instructions to reproduce the builds, so you can make your own binaries if you want. And GitHub is not an authority for Mesa in any way, since Mesa has long moved to GitLab@FreeDekstop.

10110111 · 2023-09-16T06:50:03Z

guide/ch_advanced_use.tex

+You must decide whether this is really beneficial in your situation. The libraries don't provide and additional graphics features that Stellarium make use of.
+
+\begin{itemize}
+\item Download the latest ``release-msvc'' package as you need from \url{https://github.com/pal1000/mesa-dist-win/releases} and unpack it somewhere.


The instructions seem out of date, referring to the previous source of packages.

gzotti · 2023-09-16T08:49:42Z

I see no changes in .appveyor.yml file

Yes, nothing done yet. Where do I put the new Mesa libraries in stellarium-data before I start? I am not familiar with the Github "release" thing. In case you can "unrelease" something, you can BTW remove the Mesa23 stuff.

alex-w · 2023-09-18T04:36:39Z

Yes, nothing done yet. Where do I put the new Mesa libraries in stellarium-data before I start? I am not familiar with the Github "release" thing. In case you can "unrelease" something, you can BTW remove the Mesa23 stuff.

Just follow link https://github.com/Stellarium/stellarium-data/releases/new and put the text and data

alex-w · 2023-09-30T06:50:11Z

@gzotti do you really want to replace dll for Qt6-based packages?

gzotti · 2023-09-30T08:19:37Z

Yes, I see >8fps for this Mesa20, vs. 6fps for Qt6's Mesa11.2.
I have not tested the program thoroughly, so far. Not sure if something breaks now.

alex-w · 2023-10-02T17:08:49Z

Ok, it’s look complete now

gzotti · 2023-10-02T18:00:25Z

OK, Must test if Qt5 works with all 3 options now...

alex-w · 2023-10-04T10:20:55Z

OK, Must test if Qt5 works with all 3 options now...

Works for Qt6, but not for Qt5 builds :(

gzotti · 2023-10-09T19:01:04Z

Qt6 solution: finished.

Qt5 solutions:
x64:
Do you now exclude the OpenGL libraries from Qt5.6 entirely? We still need libEGL.dll and libGLESv2.dll from there. Only the opengl32sw.dll is replaced by the newer one.

log_Qt5-x64-ANGLE.txt

log_Qt5-x64-ANGLEdx11.txt

log_Qt5-x64_ANGLE_qt5.6EGLstuff.txt

log_Qt5-x64-ANGLEdx11_qt5.5EGLstuff.txt [sorry, misspelled, 5.6...]

x32: tomorrow (download limit exceeded...)

alex-w

I think this PR can be merged and we should publish a snapshot for testing on various users hardware

github-actions · 2023-10-14T04:37:19Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2023-10-14T04:41:51Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions · 2023-10-23T08:01:41Z

Hello @gzotti!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

github-actions · 2023-12-23T11:53:46Z

Hello @gzotti!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

gzotti added importance: medium A bit annoying, minor miscalculation, but no crash infrastructure Infrastructure related issues qt Issues, related to Qt framework mesa Issues, related to MESA labels Sep 16, 2023

gzotti added this to the 23.4 milestone Sep 16, 2023

gzotti requested review from alex-w and 10110111 September 16, 2023 01:17

gzotti added this to Needs triage in OpenGL/GLSL via automation Sep 16, 2023

gzotti added this to Needs triage in OS: Windows via automation Sep 16, 2023

gzotti assigned alex-w, 10110111 and gzotti Sep 16, 2023

10110111 reviewed Sep 16, 2023

View reviewed changes

github-actions bot added the has conflicts The pull request has conflicts label Oct 5, 2023

This comment was marked as resolved.

Sign in to view

github-actions bot removed the has conflicts The pull request has conflicts label Oct 5, 2023

This comment was marked as resolved.

Sign in to view

alex-w and others added 9 commits October 14, 2023 02:58

[publish] another fix for another stupid typo

e29ab4c

[publish] hmm... let's try to fix previous commit

8417dc8

[publish] cosmetic fix

132ff97

[publish] fixed another stupid typo :(

10653f3

[publish] restore extra libGLES for Qt5-based packages

402fe95

Request/override required OpenGL version.

3d1b33d

Improve error message

d70b168

Add more warnings for out-of-memory

21590a0

Somewhat cleaner error handling.

5bb0a17

gzotti force-pushed the modernize-mesa branch from 75b16d7 to 5bb0a17 Compare October 14, 2023 01:03

gzotti marked this pull request as ready for review October 14, 2023 01:04

github-actions bot requested a review from 10110111 October 14, 2023 01:05

alex-w approved these changes Oct 14, 2023

View reviewed changes

OS: Windows automation moved this from Needs triage to In progress Oct 14, 2023

OpenGL/GLSL automation moved this from Needs triage to In progress Oct 14, 2023

github-actions bot added the has conflicts The pull request has conflicts label Oct 14, 2023

Merge branch 'master' into modernize-mesa

67cfb74

github-actions bot removed the has conflicts The pull request has conflicts label Oct 14, 2023

alex-w mentioned this pull request Oct 14, 2023

Publish Windows on Arm build #3452

Merged

gzotti merged commit 1850c07 into master Oct 14, 2023
18 of 20 checks passed

OS: Windows automation moved this from In progress to Done Oct 14, 2023

gzotti deleted the modernize-mesa branch October 14, 2023 17:08

OpenGL/GLSL automation moved this from In progress to Done Oct 14, 2023

alex-w added the state: published The fix has been published for testing in weekly binary package label Oct 23, 2023

gzotti mentioned this pull request Oct 23, 2023

Provide Mesa3d V23.1.7 libraries for Windows #3409

Closed

13 tasks

alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernize Mesa library #3414

Modernize Mesa library #3414

gzotti commented Sep 16, 2023

github-actions bot commented Sep 16, 2023

alex-w commented Sep 16, 2023

10110111 Sep 16, 2023

gzotti Sep 16, 2023

10110111 Sep 16, 2023

10110111 Sep 16, 2023

gzotti Sep 16, 2023

10110111 Sep 16, 2023

10110111 Sep 16, 2023

gzotti Sep 16, 2023 •

edited

10110111 Sep 16, 2023 •

edited

10110111 Sep 16, 2023

gzotti commented Sep 16, 2023

alex-w commented Sep 18, 2023

alex-w commented Sep 30, 2023

gzotti commented Sep 30, 2023 •

edited

alex-w commented Oct 2, 2023

gzotti commented Oct 2, 2023

alex-w commented Oct 4, 2023

This comment was marked as resolved.

This comment was marked as resolved.

gzotti commented Oct 9, 2023

This comment was marked as resolved.

alex-w left a comment

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 23, 2023

github-actions bot commented Dec 23, 2023

Modernize Mesa library #3414

Modernize Mesa library #3414

Conversation

gzotti commented Sep 16, 2023

Description

Screenshots (if appropriate):

Type of change

How Has This Been Tested?

Checklist:

github-actions bot commented Sep 16, 2023

alex-w commented Sep 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gzotti Sep 16, 2023 • edited

Choose a reason for hiding this comment

10110111 Sep 16, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gzotti commented Sep 16, 2023

alex-w commented Sep 18, 2023

alex-w commented Sep 30, 2023

gzotti commented Sep 30, 2023 • edited

alex-w commented Oct 2, 2023

gzotti commented Oct 2, 2023

alex-w commented Oct 4, 2023

This comment was marked as resolved.

This comment was marked as resolved.

gzotti commented Oct 9, 2023

This comment was marked as resolved.

alex-w left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 14, 2023

github-actions bot commented Oct 23, 2023

github-actions bot commented Dec 23, 2023

gzotti Sep 16, 2023 •

edited

10110111 Sep 16, 2023 •

edited

gzotti commented Sep 30, 2023 •

edited