Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support the origins of names #3457

Merged
merged 1 commit into from Oct 11, 2023
Merged

Add support the origins of names #3457

merged 1 commit into from Oct 11, 2023

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Oct 11, 2023

Description

Added ability to display planet nomenclature information (origins of names)

Fixes #3455 (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w alex-w linked an issue Oct 11, 2023 that may be closed by this pull request
Display planet nomenclature information #3455
Closed
@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

gzotti
gzotti approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great new feature for all people remotely interested in the origin of all those names, thanks!

@alex-w alex-w merged commit 3e5c54b into master Oct 11, 2023
23 checks passed
@alex-w alex-w deleted the nomenclature/information branch October 11, 2023 11:13
@alex-w alex-w added this to the 23.4 milestone Oct 11, 2023
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Oct 23, 2023
@github-actions
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 23, 2023
@github-actions GitHub Actions
Copy link

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzotti gzotti gzotti approved these changes

@10110111 10110111 Awaiting requested review from 10110111

Assignees

@alex-w alex-w

Labels
None yet
Projects
None yet
Milestone
23.4
Development

Successfully merging this pull request may close these issues.

Display planet nomenclature information
2 participants
@alex-w @gzotti