Fix crash in StelTexture destructor on exit #3541
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
Good find! However, it may not have been all to solve. It still reported a crash.
|
On deletion of StelApp StelTextureMgr is deleted, after which some instances of StelTexture are deleted. But StelTexture destructor logs VRAM usage via StelTextureMgr, accessing a no longer existing object. This commit turns the nonstatic raw pointer to texture manager into a static weak pointer (QPointer), so that it was possible to check whether texture manager still exists before trying to access it. Making it static is supposed to prevent useless copying of this smart pointer while the texture manager is effectively a singleton. Fixes Stellarium#3427
10110111
force-pushed
the
fix-texman-tex-crash-on-exit
branch
from
65fecfe
to
78c0146
Compare
|
The new version should fix this too. |
|
Did you update? It shouldn't even reach this line any more. |
It was for previous code, let me check it again |
|
Confirmed also in W11. I wonder why it takes minutes to shutdown the application when running a debug session. But finally it came to an end without error. |
alex-w
added
the
state: published
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @10110111! Please check the latest stable version of Stellarium: |
On deletion of
StelAppStelTextureMgris deleted, after which some instances ofStelTextureare deleted. ButStelTexturedestructor logs VRAM usage viaStelTextureMgr, accessing a no longer existing object.This commit turns the nonstatic raw pointer to texture manager into a static weak pointer (
QPointer), so that it was possible to check whether texture manager still exists before trying to access it. Making it static is supposed to prevent useless copying of this smart pointer while the texture manager is effectively a singleton.Fixes #3427