Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pinyin transliteration to Chinese sky culture #867

Merged
merged 4 commits into from Dec 2, 2019

Conversation

sunshuwei
Copy link
Contributor

Added Pinyin transliteration to Chinese sky culture.

@alex-w alex-w requested review from alex-w and gzotti November 29, 2019 18:19
Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a lot of work, thank you. I cannot discuss correct spelling with you, so I must assume this is correct. It is only a data change, so I approve.

However, it reminds me of the fact that we must deal with skyculture and language issues sooner or later. (Rather later in 2020.) The number of translatable strings is exploding, and this is a case for untranslatable strings. Or would Pinyin transliterations be translated/translitered again to other scripts systems?

@sunshuwei
Copy link
Contributor Author

Pinyin wikipedia
https://en.wikipedia.org/wiki/Pinyin
Google Translate can display pinyin while typing Chinese.

It should be difficult to transliterate into other languages again, and seem to be treated as untranslatable strings.
Pinyin can accurately express the pronunciation of Chinese characters by defining the pronunciation of each Latin letter. The system includes four diacritics denoting tones. It is difficult for other letters to reconstruct a set of spelling rules. It can also be used if denoting tones is cancelled, but it will cause a lot of homophones. (In fact, homophones cannot be completely avoided even with denoting tones.)

Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Pinyin data should be untranslatable here, but we do not support this scheme in planetarium at the moment. Seems this is new one good point for catch into the specification of second edition of skycultures (and unification of course).

I know, it may be not very good from developers side, but this is very good for translators side - could you add comments for translators for Pinyin strings?

@alex-w alex-w added this to the 0.19.3 milestone Dec 2, 2019
@alex-w alex-w added enhancement Improve existing functionality data Missing/bad/outdated data, but no code error translations Missing/bad/outdated translations, but no code error labels Dec 2, 2019
@alex-w alex-w merged commit 2e3204a into Stellarium:master Dec 2, 2019
@sunshuwei sunshuwei deleted the 2019-1125-chi branch September 19, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Missing/bad/outdated data, but no code error enhancement Improve existing functionality translations Missing/bad/outdated translations, but no code error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants