Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Mine Cells #22

Closed
ZiLenTz opened this issue Apr 7, 2024 · 7 comments
Closed

Incompatibility with Mine Cells #22

ZiLenTz opened this issue Apr 7, 2024 · 7 comments
Labels
bug Something isn't working compatibility Compatibility with another mod crash Bug that causes a crash

Comments

@ZiLenTz
Copy link

ZiLenTz commented Apr 7, 2024

Hi, I've been using this mod for a while with no issue and it works great.
However, teleporting to one of Mine Cells dimensions, Promenade of The Condemned or minecells:promenade, will result in disconnecting the player and crashing the server.

To be specific, that dimension can't be generated with Noisium.
Also, based on a crash log, it seems like the issue is related to NoiseChunkGenerator from Noisium.
Right now I have to play without Noisium since removing it solved the issue.

Crash Log: https://mclo.gs/QFFDEI0

Minecraft 1.20.1
Fabric Loader 0.15.7
Noisium 2.0.1
Mine Cells 1.7.2

Portal to Promenade of The Condemned (minecells:promenade)
2024-04-07_00 36 44

@Steveplays28 Steveplays28 added bug Something isn't working compatibility Compatibility with another mod crash Bug that causes a crash labels Apr 7, 2024
@Steveplays28
Copy link
Owner

Hi ZiLenTz, thanks for the report. I'll look into this issue!

@HaXrDEV
Copy link

HaXrDEV commented Apr 10, 2024

Reverting Noisium back to v1.0.2 seems to solve the issue for me.

@mim1q
Copy link

mim1q commented Apr 10, 2024

Hey, Mine Cells dev here, I'd be happy to help try and figure out this issue and fix it if the fault is on my end 😅

I believe the issue might be related to one of my custom density functions, where I sample a noise in a not-so-conventional way. (not the best at writing that type of thing, so I'd appreciate any suggestions for improvements in the code, and a possible way to fix this crash!)

@Steveplays28
Copy link
Owner

Steveplays28 commented Apr 11, 2024

@mim1q Hi mim1q, thanks for reaching out. I haven't figured out why it occurs on my end (when it doesn't with vanilla + MineCells).
I'll do some investigating and write back.

@ZiLenTz
Copy link
Author

ZiLenTz commented Apr 12, 2024

Really appreciate both of your responses!

Thanks for your hard work!

@Steveplays28
Copy link
Owner

I found where the issue happens. The chunk section locking goes out of bounds when accessing the arrays of chunk sections in noisium$populateNoiseInject. For some reason it's looping over more chunk sections than it's allocating to the array.
Might be an issue on my end, will take a further look

@Steveplays28
Copy link
Owner

@ZiLenTz @mim1q Should be fixed in v2.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility Compatibility with another mod crash Bug that causes a crash
Projects
None yet
Development

No branches or pull requests

4 participants