Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastlane: Use Netrc gem #3663

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Fastlane: Use Netrc gem #3663

merged 2 commits into from
Apr 15, 2019

Conversation

rye
Copy link
Member

@rye rye commented Apr 15, 2019

Rather than (naïvely and indiscriminately appending to ~/.netrc, this commit introduces the netrc gem, which we can use for reading from and writing to netrc files just the same.

Resolves #3662.

Rather than (naively and indiscriminately appending to ~/.netrc, this
commit introduces the netrc gem, which we can use for reading from and
writing to netrc files just the same.

[GitHub] This commit resolves #3662.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@rye rye added this to the v2.8.0 milestone Apr 15, 2019
@rye rye requested review from hawkrives and drewvolz April 15, 2019 01:25
@rye rye self-assigned this Apr 15, 2019
@stodevx-bot
Copy link

stodevx-bot commented Apr 15, 2019

This PR modified important files but does not have any changes to the CHANGELOG.
  • Gemfile
  • fastlane/lib/commands.rb

Generated by 🚫 dangerJS against bf9b977

Copy link
Member

@hawkrives hawkrives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind leaving the comment?

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@rye rye merged commit 66ace05 into master Apr 15, 2019
@rye rye deleted the fastlane-use-netrc branch April 15, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

authorize_ci_for_keys inappropriately writes to ~/.netrc
3 participants