Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Byte Size to Output #5

Closed
wants to merge 1 commit into from
Closed

Conversation

super3
Copy link

@super3 super3 commented Nov 23, 2014

From my understanding you need a need to have the byte length AND the seed to regenerate a pair. Added it to the output. @EmergentBehavior Have no idea how to integrate this with Redit.

fixing tests

keep the type the same

using nano and cant see tabs
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2be327f on super3:bytesize into 566ab0f on Storj:master.

@EmergentBehavior
Copy link

This is true, but basically I set it so within a single run you're assuming all the byte lengths are the same size. Then I include that in the file name or somewhere else for reference. Including it in the file itself would be more self-contained, but the problem is it's very redundant to include the same string thousands of times.

If we wanted to make it self-contained (not including Redis), then perhaps we could include the size in the beginning of the output before writing any pairs. Then we'd just have to know to read that in properly first.

For Redis I think this might work: Redis databases are given integer names, so if we're generating pairs for a 10-byte length seed, we could push those pairs to database 10, push 7-byte length to db 7, etc.

@super3
Copy link
Author

super3 commented Nov 23, 2014

Ok attempting this in #7

@super3 super3 closed this Nov 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants