This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Remove graphql, fix isFreeTier issue, fix credit card removal issue #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove graphql references and code - add helmet for security considerations
- use dotenv to handle env variables for local dev - remove a stripe test key from vc - remove some comments
|
This pull request also fixes |
phutchins
reviewed
Sep 9, 2017
lib/engine.js
Outdated
| @@ -40,6 +43,7 @@ Engine.prototype.start = function(callback) { | |||
| var self = this; | |||
|
|
|||
| log.info('starting the billing engine'); | |||
| log.info(`connecting to mongoose on ${self._config.storage.mongoURI}`); | |||
There was a problem hiding this comment.
We should make sure that we're not possibly logging credentials here in the Mongo URI.
| @@ -41,70 +41,149 @@ PaymentProcessorsRouter.prototype._addPaymentProcessor = function(req) { | |||
| }); | |||
| }; | |||
|
|
|||
| // PaymentProcessorsRouter.prototype._setUserFreeTier = function(req, isFreeTier) { | |||
There was a problem hiding this comment.
Why are we committing commented code?
- removes commented code - removes unnecessary log line
phutchins
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
isFreeTieruser issuesaddressing issues #64 and #65