This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
WIP updates lastSeen in recordResponseTime function in contact model #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonf
reviewed
Feb 26, 2018
lib/models/contact.js
Outdated
| @@ -190,6 +190,7 @@ ContactSchema.methods.recordResponseTime = function(responseTime) { | |||
| const newResponseTime = responseTime * k + lastResponseTime * (1 - k); | |||
|
|
|||
| this.responseTime = newResponseTime; | |||
| this.lastSeen = Date.now(); | |||
There was a problem hiding this comment.
recordResponseTime is also used when there is a timeout, the responseTime is the amount of time it took to timeout in that case. So it doesn't necessary mean that the contact was seen here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In process of closing storj-archived/bridge#557 .
We want to use the lastSeen metric to decide when to send ALLOC messages to contacts.
This needs to be merged before storj-archived/bridge#577 , in order to make sure that every contact has updated lastSeen time.