This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of github.com:storj/service-storage-models: Bump to 8.6.0 Add hmac to file meta Bump to 8.5.0 Add more tests and add return to next Apply concurrency fix to download bytes Fix concurrency bytes bug Clean up before tests Only run *.unit.js files in tests Add failing test Fix pubkey email validation Add test case for pubkey email ; Change contact model userAgent to not be required Add test case for failed validation Prevent duplicate referral docs with same sender and recipient and add count to track multiple sends Update to have MIN_SPENT_REQUIREMENT constant and check for promo_referral_id for referral credits Add .tern-port files and yarn.lock to .gitignore
phutchins
approved these changes
Feb 28, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
braydonf
suggested changes
Feb 28, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code coverage decreased, needs some tests.
All checks now passing and tests added. Looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.