This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Verify checksum of Ethereum payout addresses #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a payout address uses mixed case, it must be according to EIP-55: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.md Only lower- or only uppercase addresses are still valid as well.
braydonf
reviewed
Sep 27, 2017
| @@ -13,6 +13,7 @@ const du = require('du'); // Get amount used | |||
| const disk = require('diskusage'); // Get amount free | |||
| const assert = require('assert'); | |||
| const bytes = require('bytes'); | |||
| const web3utils = require('web3-utils'); | |||
There was a problem hiding this comment.
Where is the github for this? The npm page goes to a 404
There was a problem hiding this comment.
There was a problem hiding this comment.
K, thanks. Looks like this is the code for isAddress https://github.com/ethereum/web3.js/blob/1.0/packages/web3-utils/src/utils.js#L87
There was a problem hiding this comment.
The important part is checkAddressChecksum that gets called at the end of isAddress
https://github.com/ethereum/web3.js/blob/1.0/packages/web3-utils/src/utils.js#L109
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a payout address uses mixed case, it must be according to EIP-55.
Only lower- or only uppercase addresses are still valid as well.