Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compiling only with resolve-file feature #358

Closed
qdot opened this issue Apr 19, 2022 · 1 comment · Fixed by #360
Closed

Allow compiling only with resolve-file feature #358

qdot opened this issue Apr 19, 2022 · 1 comment · Fixed by #360

Comments

@qdot
Copy link

qdot commented Apr 19, 2022

If jsonschema is included using the following file:

jsonschema = { version = "0.15.2", default-features = false, features = ["resolve-file"] }

builds will fail at https://github.com/Stranger6667/jsonschema-rs/blob/master/jsonschema/src/resolver.rs#L85 because of the compile_error. I'm in a situation where I only want to load schemas off local storage and do not need http resolution access.

The same check happens at line 102 (https://github.com/Stranger6667/jsonschema-rs/blob/master/jsonschema/src/resolver.rs#L102) in order to throw an error, but we'll never reach that because of the compile error so we can't even build in the first place.

@samueldotj
Copy link

#359 is most likely same as this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants