Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): StreamingServer Settings.remote_https uses null while stremio 4 uses empty string, with tests #702

Merged
merged 21 commits into from
Jul 31, 2024
Merged

fix(core): StreamingServer Settings.remote_https uses null while stremio 4 uses empty string, with tests #702

merged 21 commits into from
Jul 31, 2024

Conversation

DoomHEADSHOT
Copy link
Member

@DoomHEADSHOT DoomHEADSHOT commented Jul 8, 2024 •
edited

@DoomHEADSHOT DoomHEADSHOT requested a review from elpiel July 8, 2024 13:11
elpiel
elpiel requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, a few tweaks and clean up is needed before merging.

src/types/streaming_server/settings.rs Outdated Show resolved Hide resolved
src/types/streaming_server/settings.rs Outdated Show resolved Hide resolved
src/types/streaming_server/settings.rs Outdated Show resolved Hide resolved
src/types/streaming_server/settings.rs Outdated Show resolved Hide resolved
@DoomHEADSHOT DoomHEADSHOT requested a review from elpiel July 10, 2024 09:02
elpiel
elpiel requested changes Jul 11, 2024
View reviewed changes
src/types/streaming_server/settings.rs Outdated Show resolved Hide resolved
src/types/streaming_server/serde_ext.rs Outdated Show resolved Hide resolved
DoomHEADSHOT and others added 3 commits July 11, 2024 10:20
@DoomHEADSHOT @elpiel
Update src/types/streaming_server/settings.rs
78a3fee 
Co-authored-by: Lachezar Lechev <8925621+elpiel@users.noreply.github.com>
@DoomHEADSHOT
WIP: b57b002 Merge branch 'fix/EmptyStringBug' of github.com:DoomHEAD…
65cedfd 
…SHOT/stremio-core into fix/EmptyStringBug
@DoomHEADSHOT
Merge branch 'fix/EmptyStringBug' of github.com:DoomHEADSHOT/stremio-…
f3006b5 
…core into fix/EmptyStringBug
@DoomHEADSHOT DoomHEADSHOT requested a review from elpiel July 15, 2024 11:51
@DoomHEADSHOT DoomHEADSHOT requested a review from elpiel July 15, 2024 12:19
@elpiel elpiel changed the title fix: core uses null while stremio 4 uses empty string , with tests fix(core): StreamingServer Settings.remote_https uses null while stremio 4 uses empty string, with tests Jul 17, 2024
@elpiel elpiel mentioned this pull request Jul 22, 2024
Open
@elpiel
Copy link
Member

elpiel commented Jul 22, 2024

Tested and works with the web changes made in:
Stremio/stremio-web#663

@kKaskak kKaskak self-requested a review July 22, 2024 11:44
@elpiel elpiel merged commit 4cb5708 into Stremio:development Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpiel elpiel elpiel approved these changes

@kKaskak kKaskak kKaskak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DoomHEADSHOT @elpiel @kKaskak