fix: Streaming server settings - use empty string instead of null for remoteHttps #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remoteHttps Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
kKaskak
approved these changes
Jul 22, 2024
|
It needs to be changed in server and desktop because we shouldn't use and empty string as |
TODOs
|
|
Ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the UI fix for the core's change to use empty string instead of
null. This is in-par with Desktop and it will now use the same options on web and Desktop.Needs core: Stremio/stremio-core#702