Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure out why express 3.4.4 broke github webhooks.... #247

Closed
jaredly opened this issue Nov 1, 2013 · 1 comment
Closed

figure out why express 3.4.4 broke github webhooks.... #247

jaredly opened this issue Nov 1, 2013 · 1 comment
Assignees
Labels

Comments

@jaredly
Copy link
Member

jaredly commented Nov 1, 2013

I pinned to 3.4.2, but it would be good to figure out what happened and write a test for it.

2013-11-01T05:34:40.133576+00:00 app[web.1]:     buf.copy(buffer, pos);
2013-11-01T05:34:40.133142+00:00 app[web.1]:
2013-11-01T05:34:40.133576+00:00 app[web.1]:         ^
2013-11-01T05:34:40.136386+00:00 app[web.1]:     at Function.Buffer.concat (buffer.js:499:9)
2013-11-01T05:34:40.133269+00:00 app[web.1]: buffer.js:499
2013-11-01T05:34:40.136386+00:00 app[web.1]: TypeError: Object payload=%7B%22ref%22%3A%22refs%2Fheads%2Fmaster%22%2C%22after%22%3A%2234ba7ba18e7b16adbb6d8488bfff6140760d53c4%22%2C%22before%22%3A%22b1a17593d21edf7ad827e8cc61fd99cb6e34843e%22%2C%22created%22%3Afalse%2C%22deleted%22%3Afalse%2C%22forced%22%3Afalse%2C%22compare%22%3A%22https%3A%2F%2Fgithub.com%2Ffamilyfound%2Ffamilyfound%2Fcompare%2Fb1a17593d21e...34ba7ba18e7b%22%2C%22commits%22%3A%5B%7B%22id%22%3A%2234ba7ba18e7b16adbb6d8488bfff6140760d53c4%22%2C%22distinct%22%3Atrue%2C%22message%22%3A%22small%22%2C%22timestamp%22%3A%222013-10-31T22%3A32%3A37-07%3A00%22%2C%22url%22%3A%22https%3A%2F%2Fgithub.com%2Ffamilyfound%2Ffamilyfound%2Fcommit%2F34ba7ba18e7b16adbb6d8488bfff6140760d53c4%22%2C%22author%22%3A%7B%22name%22%3A%22Jared+Forsyth%22%2C%22email%22%3A%22jared%40jaredforsyth.com%22%2C%22username%22%3A%22jaredly%22%7D%2C%22committer%22%3A%7B%22name%22%3A%22Jared+Forsyth%22%2C%22email%22%3A%22jared%40jaredforsyth.com%22%2C%22username%22%3A%22jaredly%22%7D%2C%22added%22%3A%5B%5D%2C%22removed%22%3A%5B%
2013-11-01T05:34:40.136386+00:00 app[web.1]: 5D%2C%22modified%22%3A%5B%22Makefile%22%5D%7D%5D%2C%22head_commit%22%3A%7B%22id%22%3A%2234ba7ba18e7b16adbb6d8488bfff6140760d53c4%22%2C%22distinct%22%3Atrue%2C%22message%22%3A%22small%22%2C%22timestamp%22%3A%222013-10-31T22%3A32%3A37-07%3A00%22%2C%22url%22%3A%22https%3A%2F%2Fgithub.com%2Ffamilyfound%2Ffamilyfound%2Fcommit%2F34ba7ba18e7b16adbb6d8488bfff6140760d53c4%22%2C%22author%22%3A%7B%22name%22%3A%22Jared+Forsyth%22%2C%22email%22%3A%22jared%40jaredforsyth.com%22%2C%22username%22%3A%22jaredly%22%7D%2C%22committer%22%3A%7B%22name%22%3A%22Jared+Forsyth%22%2C%22email%22%3A%22jared%40jaredforsyth.com%22%2C%22username%22%3A%22jaredly%22%7D%2C%22added%22%3A%5B%5D%2C%22removed%22%3A%5B%5D%2C%22modified%22%3A%5B%22Makefile%22%5D%7D%2C%22repository%22%3A%7B%22id%22%3A10871473%2C%22name%22%3A%22familyfound%22%2C%22url%22%3A%22https%3A%2F%2Fgithub.com%2Ffamilyfound%2Ffamilyfound%22%2C%22description%22%3A%22Main+project+-+streamlining+family+history+research%22%2C%22watchers%22%3A0%2C%22stargazers%22%3A0%2C%22forks%22%
2013-11-01T05:34:40.136386+00:00 app[web.1]:     at IncomingMessage.onEnd (/app/node_modules/express/node_modules/connect/node_modules/raw-body/index.js:57:29)
2013-11-01T05:34:40.136386+00:00 app[web.1]:     at IncomingMessage.g (events.js:175:14)
2013-11-01T05:34:40.136386+00:00 app[web.1]:     at IncomingMessage.EventEmitter.emit (events.js:92:17)
2013-11-01T05:34:40.136386+00:00 app[web.1]:     at _stream_readable.js:920:16
2013-11-01T05:34:40.136386+00:00 app[web.1]:     at process._tickCallback (node.js:415:13)
2013-11-01T05:34:40.136386+00:00 app[web.1]: 3A0%2C%22fork%22%3Afalse%2C%22size%22%3A712%2C%22owner%22%3A%7B%22name%22%3A%22familyfound%22%2C%22email%22%3A%22%22%7D%2C%22private%22%3Afalse%2C%22open_issues%22%3A9%2C%22has_issues%22%3Atrue%2C%22has_downloads%22%3Atrue%2C%22has_wiki%22%3Atrue%2C%22language%22%3A%22JavaScript%22%2C%22created_at%22%3A1371930870%2C%22pushed_at%22%3A1383284079%2C%22master_branch%22%3A%22master%22%2C%22organization%22%3A%22familyfound%22%7D%2C%22pusher%22%3A%7B%22name%22%3 has no method 'copy'
2013-11-01T05:34:41.254699+00:00 heroku[web.1]: Process exited with status 8
@niallo
Copy link
Member

niallo commented Dec 1, 2013

Explanation is in #286.

@niallo niallo closed this as completed Dec 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants