Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pako to 1.0.2 #320

Closed
puzrin opened this issue Jul 21, 2016 · 2 comments
Closed

Update pako to 1.0.2 #320

puzrin opened this issue Jul 21, 2016 · 2 comments

Comments

@puzrin
Copy link
Contributor

puzrin commented Jul 21, 2016 •
edited
Loading

nodeca/pako#78

Bug is in deflate, inflate not affected. No problem if jszip used as node npm module, but i strongly recommend to update browserified builds. Probably, it also worth to backport this to 2.x and 1.x versions if those are used wide.

Pako's mainstream version is now 1.0.2 (semver). 0.2.9 is equal to 1.0.2 and released to give change to old dependents.
@puzrin puzrin changed the title Update pako to 1.0.2 or 0.2.9 Update pako to 1.0.2 Jul 21, 2016
@dduponchel
Copy link
Collaborator

JSZip v1 is 3 years old and don't use pako, I think we can skip it. I'll prepare a fix + release for the v2, the v3 should get a release soon anyway.

Thanks for the issue.

dduponchel added a commit to dduponchel/jszip that referenced this issue Jul 25, 2016
@dduponchel
Update pako dependency version to 1.0.2.
5512973 
While not strictly necessary (the `~1.0.0` includes it), I prefer an explicit
commit for this change.

Related to Stuk#320, fix a bug in deflate.
dduponchel added a commit to dduponchel/jszip that referenced this issue Jul 25, 2016
@dduponchel
Update pako dependency version to 1.0.2.
39fd345 
While not strictly necessary (the `~1.0.0` includes it), I prefer an explicit
commit for this change.

Related to Stuk#320, fix a bug in deflate.
dduponchel added a commit to dduponchel/jszip that referenced this issue Jul 25, 2016
@dduponchel
Update pako dependency version to 1.0.2.
afcfb91 
While not strictly necessary (the `~1.0.0` includes it), I prefer an explicit
commit for this change.

Related to Stuk#320, fix a bug in deflate.
@dduponchel dduponchel mentioned this issue Jul 25, 2016
Merged
dduponchel added a commit to dduponchel/jszip that referenced this issue Jul 27, 2016
@dduponchel
Update pako dependency version to 1.0.2.
ac38cd1 
While not strictly necessary (the `~1.0.0` includes it), I prefer an explicit
commit for this change.

Related to Stuk#320, fix a bug in deflate.
dduponchel added a commit that referenced this issue Jul 27, 2016
@dduponchel
[backport] Update pako dependency version to 1.0.2.
f494be6 
While not strictly necessary (the `~1.0.0` includes it), I prefer an explicit
commit for this change.

Related to #320, fix a bug in deflate.
@dduponchel
Copy link
Collaborator

Fixed and released in v2.6.1 and v3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dduponchel @puzrin