separate attribution comment & use "/*!" for it #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "/*!" to ensure attribution comment is preserved by minifiers
|
Thanks for the pull request ! I just merged #74 which changes a lot of things regarding the generated/minified file (now we use grunt + browserify + uglify). The issue remains (the license is lost) but your commit is not enough anymore. |
dduponchel
added a commit
to dduponchel/jszip
that referenced
this pull request
Jan 15, 2014
This commit updates the grunt configuration to ensure that the license comment (starting with /*! for the minifiers) makes its way to the final dist files.
|
Closing per #81. |
dduponchel
added a commit
that referenced
this pull request
Feb 1, 2014
change the grunt config for the issue #80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "/*!" to ensure attribution comment is preserved by minifiers.