separate attribution comment & use "/*!" for it #80

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@cvrebert
Contributor

Use "/*!" to ensure attribution comment is preserved by minifiers.

@cvrebert cvrebert separate attribution comment & use "/*!" for it
Use "/*!" to ensure attribution comment is preserved by minifiers
8703f4c
@dduponchel
Collaborator

Thanks for the pull request ! I just merged #74 which changes a lot of things regarding the generated/minified file (now we use grunt + browserify + uglify). The issue remains (the license is lost) but your commit is not enough anymore.
I fixed the grunt configuration to ensure that your fix is effective and I will create a pull request including your commit. As soon as @Stuk reviews/accepts it, this pull request will be automatically resolved.

@dduponchel dduponchel added a commit to dduponchel/jszip that referenced this pull request Jan 15, 2014
@dduponchel dduponchel change the grunt config for the issue #80
This commit updates the grunt configuration to ensure that the license
comment (starting with /*! for the minifiers) makes its way to the final
dist files.
023cdbf
@cvrebert
Contributor

Closing per #81.

@cvrebert cvrebert closed this Jan 15, 2014
@cvrebert cvrebert deleted the unknown repository branch Jan 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment