New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate attribution comment & use "/*!" for it #80

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@cvrebert
Contributor

cvrebert commented Jan 14, 2014

Use "/*!" to ensure attribution comment is preserved by minifiers.

separate attribution comment & use "/*!" for it
Use "/*!" to ensure attribution comment is preserved by minifiers
@dduponchel

This comment has been minimized.

Show comment
Hide comment
@dduponchel

dduponchel Jan 15, 2014

Collaborator

Thanks for the pull request ! I just merged #74 which changes a lot of things regarding the generated/minified file (now we use grunt + browserify + uglify). The issue remains (the license is lost) but your commit is not enough anymore.
I fixed the grunt configuration to ensure that your fix is effective and I will create a pull request including your commit. As soon as @Stuk reviews/accepts it, this pull request will be automatically resolved.

Collaborator

dduponchel commented Jan 15, 2014

Thanks for the pull request ! I just merged #74 which changes a lot of things regarding the generated/minified file (now we use grunt + browserify + uglify). The issue remains (the license is lost) but your commit is not enough anymore.
I fixed the grunt configuration to ensure that your fix is effective and I will create a pull request including your commit. As soon as @Stuk reviews/accepts it, this pull request will be automatically resolved.

dduponchel added a commit to dduponchel/jszip that referenced this pull request Jan 15, 2014

change the grunt config for the issue #80
This commit updates the grunt configuration to ensure that the license
comment (starting with /*! for the minifiers) makes its way to the final
dist files.
@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Jan 15, 2014

Contributor

Closing per #81.

Contributor

cvrebert commented Jan 15, 2014

Closing per #81.

@cvrebert cvrebert closed this Jan 15, 2014

@cvrebert cvrebert deleted the cvrebert:patch-1 branch Jan 15, 2014

dduponchel added a commit that referenced this pull request Feb 1, 2014

Merge pull request #81 from dduponchel/grunt-issue-80
change the grunt config for the issue #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment