Improve browser testing #269

Merged
merged 5 commits into from Mar 22, 2016

Projects

None yet

2 participants

@evilaliv3
Contributor

I've updated the selection of browser on which the libraries is tested.

index.html should be probably updated.

It is important nowadays to asses that the library is functiioning on IE11, Edge, and latest Android / Iphone that are all missing.

I would be a nice to have to start assessing also the code coverage of the tests exectuted on the library, and this would allow to spot deadbranches and outdated code.

@dduponchel
Collaborator

👍 for the missing browsers/nodejs versions.
Did you test the edge browser ? I can't start the test with edge as browser name but it works fine with microsoftedge.

Code coverage would be nice indeed. The results would be a bit off (some code paths are here only for some platforms) but that would be a start.

@dduponchel dduponchel commented on the diff Mar 20, 2016
README.markdown
@@ -1,4 +1,7 @@
-JSZip
+JSZip [![Build Status](https://api.travis-ci.org/Stuk/jszip.svg?branch=master)](http://travis-ci.org/Stuk/jszip) [![Code Climate](https://codeclimate.com/github/Stuk/jszip/badges/gpa.svg)](https://codeclimate.com/github/Stuk/jszip)
@dduponchel
dduponchel Mar 20, 2016 Collaborator

Putting the images here break the title. Any reason to move the build status ?
Also, I wouldn't put the codeclimate badge: the final score makes little sense as it currently includes generated files.

@evilaliv3
Contributor

you are right, probably we should write microsoftedge.

for what relates to putting the results on the top i like how it will come out like:
https://github.com/ghostbar/angular-zxcvbn

what do you think?

@dduponchel
Collaborator

For the badges in the title, you need to put the line with ===== just below the title line with all the badges. Something like:

JSZip [badge1] [badge2] ...
=====

[saucelabs image]

I'm curious about codeclimate: why this one and not an other ?

@evilaliv3
Contributor

i'm experimenting with CodeClimate and Landscape.io

The first can provide you both the badges for their linter(that is anyhow unique in the suggestions and it's improving) and the coverage badge for the results you publish to them; The latter is more traditional and do only the linting, so you should eventually also setup Coveralls.io for that.

Any concern?

@evilaliv3
Contributor

Here you go :)

@dduponchel
Collaborator

I never used these tools as a service and a quick search about code quality and github integration showed plenty of competitors, hence my question.
I'm ok with CodeClimate but you will need in that case to add the .codeclimate.yml file :-)

@dduponchel dduponchel and 1 other commented on an outdated diff Mar 21, 2016
README.markdown
@@ -1,4 +1,8 @@
-JSZip
+JSZip [![Build Status](https://api.travis-ci.org/Stuk/jszip.svg?branch=master)](http://travis-ci.org/Stuk/jszip) [![Code Climate](https://codeclimate.com/github/Stuk/jszip/badges/gpa.svg)](https://codeclimate.com/github/Stuk/jszip)
+=====
+
+[![Selenium Test Status](https://saucelabs.com/browser-matrix/jszip.svg)](https://saucelabs.com/u/jszip)
+
=====
@dduponchel
dduponchel Mar 21, 2016 Collaborator

This line was here to format "JSZip" as a title but since you added an other one above, you should remove it (it generates an empty title line, see here).

@evilaliv3
Contributor

we do not need any .codeclimate.yml; that is only if you would like to give specific directives.

@evilaliv3
Contributor

bam bam bam!

@dduponchel
Collaborator

But if we don't have any .codeclimate.yml to exclude dist/ files, we will keep a meaningless score. Either add this conf file to get a meaningful score or remove the CodeClimate badge.

@evilaliv3
Contributor

bam bam bam bam!

@dduponchel dduponchel merged commit d3e6dbd into Stuk:master Mar 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dduponchel
Collaborator

Thanks !

@evilaliv3
Contributor

you are welcome @dduponchel

i just noticed that codeclimate do not accept partial configurations, so you would need to load this complete one or it will give you an error: evilaliv3@d8f4e5b

sorry for not noticing that before.

@dduponchel
Collaborator

Could you create an other pull request with the updated config file ?

@evilaliv3
Contributor

here you go: #271

This was referenced Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment