Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Snippet Editor #75

Closed
Mottie opened this issue Jun 30, 2017 · 4 comments
Closed

Code Snippet Editor #75

Mottie opened this issue Jun 30, 2017 · 4 comments
Labels
help wanted 🙏 Extra attention is needed

Comments

@Mottie
Copy link
Member

Mottie commented Jun 30, 2017

See USO discussion:

  • Fix code snippet syntax highlighting (CodeMirror).
  • Fix result panel text color.
  • Darken option select background.

@Fred-Vatin
Copy link

It could be a stylus issue. It goes the same for the run the code output like here. The black text output is barely visible.

@Mottie
Copy link
Member Author

Mottie commented Jul 10, 2017

Hi @freMea

Yeah, Stylus doesn't watch for every DOM mutation to see if it added an iframe. I wouldn't expect it to. The solution here would be to remove the .snippet-box-edit definition making the result iframe dark. I still need to look at the editor when I get some time/motivation.

@Mottie Mottie added the help wanted 🙏 Extra attention is needed label Oct 11, 2017
@the-j0k3r
Copy link
Member

inverting the iframe was pretty much the only thing that saves corneas here, if anyone wants to have another go, please reopen this ticket and go for it. =)

@the-j0k3r
Copy link
Member

Ive had another go, The code Snippet thingy is mostly now decent.

Ive also added a Twilight CodeMirror syntax highlighting as the default (there are no options for this, it would be huge to add this I think.

Capture

This was the commit added these fixes 9a42a46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted 🙏 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants