Fix Sublime's expand_variables for UNC paths
#1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes SublimeLinter/SublimeLinter-eslint#276 Explainer and origin: sublimehq/sublime_text#1878 Sublime's `expand_variables` handles `\\` (two slashes) and reduces them to one. We fix by adding more slashes before substituting.
kaste
force-pushed
the
fixup-expand-variables
branch
from
1d9abaa
to
2843a8f
Compare
|
Wow, why is "Textmate compatibility" still a thing? 🚢 it, it's not like I can test this right? |
|
The current PR's are all hard to test, I also have to mock my env, run fake linter plugins. It really pays off that we have tests now. We had basically zero issues with our latest releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SublimeLinter/SublimeLinter-eslint#276
Explainer and origin: sublimehq/sublime_text#1878
Sublime's
expand_variableshandles\\(two slashes) and reduces them to one. We fix by adding more slashes before substituting.