Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mouse down/up events clutter #2

Open
SugarF0x opened this issue Dec 14, 2020 · 1 comment
Open

Mouse down/up events clutter #2

SugarF0x opened this issue Dec 14, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@SugarF0x
Copy link
Owner

MOUSE_DOWN and MOUSE_UP are only ever used within l-dungeon, so it would be better to move isMouseDown from vuex index state to this very layer and keep it there, effectively cleaning up much of the mouse event clutter in vuex history
@SugarF0x SugarF0x added the enhancement New feature or request label Dec 14, 2020
@SugarF0x
Copy link
Owner Author

Now that Tween animations are here i think that vuex log clutter is the least of my problems
Nevertheless, given that MOUSE_DOWN and MOUSE_UP are only used within dungeon either way, it's still good to contain in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SugarF0x