fix(logs): use longer fingerprint only on K8s <1.24

.changelog/3070.fixed.txt

@@ -0,0 +1 @@
+fix(logs): use longer fingerprint only on K8s <1.24

deploy/helm/sumologic/conf/logs/collector/otelcol/config.yaml

@@ -59,9 +59,12 @@ receivers:
 {{- if .Values.sumologic.logs.container.enabled }}
   ## ref: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/v0.76.1/receiver/filelogreceiver
   filelog/containers:
+{{ if lt (int .Capabilities.KubeVersion.Minor) 24 }}
     ## sets fingerprint_size to 17kb in order to match the longest possible docker line (which by default is 16kb)
     ## we want to include timestamp, which is at the end of the line
+    ## Not necessary in 1.24 and later, as docker-shim is not present anymore
     fingerprint_size: 17408
+{{ end }}
     include:
       - /var/log/pods/*/*/*.log
     include_file_name: false

tests/helm/const.go

@@ -7,6 +7,7 @@ const (
 	chartName                = "sumologic"
 	releaseName              = "collection-test"
 	defaultNamespace         = "sumologic"
+	defaultK8sVersion        = "1.22.0"
 	testDataDirectory        = "./testdata"
 	otelConfigFileName       = "config.yaml"
 	otelImageFIPSSuffix      = "-fips"

tests/helm/goldenfile_test.go

@@ -56,6 +56,8 @@ func runGoldenFileTest(t *testing.T, valuesFileName string, outputFileName strin
 		true,
 		"--namespace",
 		defaultNamespace,
+		"--kube-version",
+		defaultK8sVersion,
 	)
 
 	// render the actual and expected yaml strings and fix them up

tests/helm/logs_test.go

@@ -4,6 +4,8 @@ import (
 	"fmt"
 	"testing"
 
+	"github.com/gruntwork-io/terratest/modules/helm"
+	"github.com/gruntwork-io/terratest/modules/logger"
 	"github.com/stretchr/testify/require"
 	"gopkg.in/yaml.v3"
 )
@@ -363,6 +365,42 @@ sumologic:
 	}
 }
 
+func TestCollectorOtelConfigNoDockerShim(t *testing.T) {
+	t.Parallel()
+	templatePath := "templates/logs/collector/otelcol/configmap.yaml"
+	renderedYamlString := RenderTemplate(
+		t,
+		&helm.Options{
+			ValuesFiles: []string{},
+			SetStrValues: map[string]string{
+				"sumologic.accessId":  "accessId",
+				"sumologic.accessKey": "accessKey",
+			},
+			Logger: logger.Discard, // the log output is noisy and doesn't help much
+		},
+		chartDirectory,
+		releaseName,
+		[]string{templatePath},
+		true,
+		"--namespace",
+		defaultNamespace,
+		"--kube-version",
+		"1.24.3",
+	)
+	otelConfigYaml := GetOtelConfigFromTemplate(t, renderedYamlString)
+
+	var otelConfig struct {
+		Receivers struct {
+			Filelog struct {
+				FingerprintSize string `yaml:"fingerprint_size"`
+			} `yaml:"filelog/containers"`
+		}
+	}
+	err := yaml.Unmarshal([]byte(otelConfigYaml), &otelConfig)
+	require.NoError(t, err)
+	require.Empty(t, otelConfig.Receivers.Filelog.FingerprintSize)
+}
+
 func TestCollectorOtelConfigSystemdUnits(t *testing.T) {
 	t.Parallel()
 	templatePath := "templates/logs/collector/otelcol/configmap.yaml"