Skip to content

Commit

Permalink
fix(otellogs): set resources on Otelcol logs collector daemonset
Browse files Browse the repository at this point in the history
The resources were already defined in `values.yaml`
in the `otellogs.daemonset.resources` property,
but this property was not being used in the daemonset template.
  • Loading branch information
andrzej-stencel committed May 24, 2022
1 parent b1e7d4e commit 5a837fc
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- fix: set cluster field in metadata pipelines [#2284][#2284]
- fix(otellogs): set resources on Otelcol logs collector daemonset [#2291]

[#2284]: https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/2284
[#2287]: https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/2287
[#2291]: https://github.com/SumoLogic/sumologic-kubernetes-collection/pull/2291
[Unreleased]: https://github.com/SumoLogic/sumologic-kubernetes-collection/compare/v2.8.0...main

## [v2.8.0]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ spec:
httpGet:
path: /
port: 13133 # Health Check extension default port.
resources:
{{- toYaml .Values.otellogs.daemonset.resources | nindent 10 }}
volumeMounts:
- mountPath: /etc/otelcol
name: otelcol-config
Expand Down
7 changes: 7 additions & 0 deletions tests/helm/logs_otc_daemonset/static/basic.output.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@ spec:
httpGet:
path: /
port: 13133 # Health Check extension default port.
resources:
limits:
cpu: 1000m
memory: 1Gi
requests:
cpu: 100m
memory: 32Mi
volumeMounts:
- mountPath: /etc/otelcol
name: otelcol-config
Expand Down

0 comments on commit 5a837fc

Please sign in to comment.