fix(metrics): drop apiserver request histograms

This was unnecessarily enabled in #2898. It's quite noisy and we don't actually use it in apps.
SumoLogic · Mar 24, 2023 · da6c327 · da6c327
1 parent c4e0805
commit da6c327
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/.changelog/2952.fixed.txt b/.changelog/2952.fixed.txt
@@ -0,0 +1 @@
+fix(metrics): drop apiserver request histograms
diff --git a/deploy/helm/sumologic/values.yaml b/deploy/helm/sumologic/values.yaml
@@ -1591,12 +1591,11 @@ kube-prometheus-stack:
       ## see docs/scraped_metrics.md
       ## apiserver_request_count
       ## apiserver_request_total
-      ## apiserver_request_duration_seconds_bucket
       ## apiserver_request_duration_seconds_count
       ## apiserver_request_duration_seconds_sum
       metricRelabelings:
         - action: keep
-          regex: (?:apiserver_request_(?:count|total)|apiserver_request_(?:duration_seconds)_(?:count|sum|bucket))
+          regex: (?:apiserver_request_(?:count|total)|apiserver_request_(?:duration_seconds)_(?:count|sum))
           sourceLabels: [__name__]
   kubelet:
     serviceMonitor:
@@ -2129,7 +2128,6 @@ kube-prometheus-stack:
         ## api server metrics:
         ## apiserver_request_count
         ## apiserver_request_total
-        ## apiserver_request_duration_seconds_bucket
         ## apiserver_request_duration_seconds_count
         ## apiserver_request_duration_seconds_sum
         ## etcd_request_cache_get_duration_seconds_count
@@ -2148,7 +2146,7 @@ kube-prometheus-stack:
           remoteTimeout: 5s
           writeRelabelConfigs:
             - action: keep
-              regex: apiserver;(?:apiserver_request_(?:count|total)|apiserver_request_(?:duration_seconds)_(?:count|sum|bucket)|etcd_helper_cache_(?:hit|miss)_(?:count|total))
+              regex: apiserver;(?:apiserver_request_(?:count|total)|apiserver_request_(?:duration_seconds)_(?:count|sum)|etcd_helper_cache_(?:hit|miss)_(?:count|total))
               sourceLabels: [job, __name__]
         ## kubelet metrics:
         ## kubelet_docker_operations_errors

diff --git a/tests/integration/internal/constants.go b/tests/integration/internal/constants.go
@@ -107,7 +107,6 @@ var (
 		"apiserver_request_total",
 		"apiserver_request_duration_seconds_count",
 		"apiserver_request_duration_seconds_sum",
-		"apiserver_request_duration_seconds_bucket",
 	}
 	KubeEtcdMetrics = []string{
 		"etcd_mvcc_db_total_size_in_bytes",