chore(metrics): remove deprecated apiserver metrics #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
fix/controller-manager-metrics
branch
from
8eb2457
to
d4ff3b1
Compare
swiatekm
force-pushed
the
fix/controller-manager-metrics
branch
from
d4ff3b1
to
4d05342
Compare
swiatekm
changed the title
swiatekm
force-pushed
the
fix/controller-manager-metrics
branch
from
4d05342
to
b8636a1
Compare
sumo-drosiek
approved these changes
Feb 28, 2023
sumo-drosiek
requested changes
Feb 28, 2023
sumo-drosiek
approved these changes
Feb 28, 2023
Not as far as I'm aware, there's a separate app for control planes on managed K8s. And they don't exist anyway, so removing them from the config doesn't change anything. |
swiatekm
pushed a commit
that referenced
this pull request
Mar 23, 2023
This was unnecessarily enabled in #2898. It's quite noisy and we don't actually use it in apps.
1 task
swiatekm
pushed a commit
that referenced
this pull request
Mar 23, 2023
This was unnecessarily enabled in #2898. It's quite noisy and we don't actually use it in apps.
swiatekm
pushed a commit
that referenced
this pull request
Mar 24, 2023
This was unnecessarily enabled in #2898. It's quite noisy and we don't actually use it in apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apiserver_request_latencies_*metrics were deprecated in 1.14 and disabled in 1.17. The current replacement areapiserver_request_duration_*. Enable checking these in integration tests.Fix another small issue in the changelog generation script as well.
Checklist